Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6011)

Unified Diff: chrome/browser/cocoa/browser_window_controller_unittest.mm

Issue 384105: Mac: Animate the bookmark bar showing/hiding. (Closed)
Patch Set: Comments added per rohitrao's review. Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/browser_window_controller.mm ('k') | chrome/browser/cocoa/toolbar_compressable.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/browser_window_controller_unittest.mm
diff --git a/chrome/browser/cocoa/browser_window_controller_unittest.mm b/chrome/browser/cocoa/browser_window_controller_unittest.mm
index e2b7451ae76d9fc7850f8147a19e49268a0637f2..b03d095d30907ed5e51bf9f72cc592c202604f25 100644
--- a/chrome/browser/cocoa/browser_window_controller_unittest.mm
+++ b/chrome/browser/cocoa/browser_window_controller_unittest.mm
@@ -105,6 +105,7 @@ TEST_F(BrowserWindowControllerTest, TestNormal) {
// Force the bookmark bar to be shown.
browser_helper_.profile()->GetPrefs()->
SetBoolean(prefs::kShowBookmarkBar, true);
+ [controller_ updateBookmarkBarVisibilityWithAnimation:NO];
// Make sure a normal BrowserWindowController is, uh, normal.
EXPECT_TRUE([controller_ isNormalWindow]);
@@ -139,7 +140,7 @@ TEST_F(BrowserWindowControllerTest, BookmarkBarControllerIndirection) {
browser_helper_.profile()->GetPrefs()->
SetBoolean(prefs::kShowBookmarkBar, true);
- [controller_ updateBookmarkBarVisibility];
+ [controller_ updateBookmarkBarVisibilityWithAnimation:NO];
EXPECT_TRUE([controller_ isBookmarkBarVisible]);
}
« no previous file with comments | « chrome/browser/cocoa/browser_window_controller.mm ('k') | chrome/browser/cocoa/toolbar_compressable.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698