chrome/browser/cocoa/browser_window_cocoa.mm - Issue 384105: Mac: Animate the bookmark bar showing/hiding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/cocoa/browser_window_cocoa.mm

Issue 384105: Mac: Animate the bookmark bar showing/hiding. (Closed)

Patch Set: Comments added per rohitrao's review. Created 11 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/cocoa/browser_window_cocoa.mm

diff --git a/chrome/browser/cocoa/browser_window_cocoa.mm b/chrome/browser/cocoa/browser_window_cocoa.mm

index 8e5b50b2b759a04ef3abc895236b76724106eac6..f38dd2dfba1f262a34dd8cbfdd4cb63428c976b2 100644

--- a/chrome/browser/cocoa/browser_window_cocoa.mm

+++ b/chrome/browser/cocoa/browser_window_cocoa.mm

@@ -423,7 +423,7 @@ void BrowserWindowCocoa::Observe(NotificationType type,

// Only the key window gets a direct toggle from the menu.

// Other windows hear about it from the notification.

case NotificationType::BOOKMARK_BAR_VISIBILITY_PREF_CHANGED:

- [controller_ updateBookmarkBarVisibility];

+ [controller_ updateBookmarkBarVisibilityWithAnimation:YES];

break;

default:

NOTREACHED(); // we don't ask for anything else!