Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8873)

Unified Diff: chrome/common/notification_details.h

Issue 384103: This patch is the rest of the lint cleanup minus the other open issue. (Closed)
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/net/socket_stream.h ('k') | chrome/common/notification_source.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/notification_details.h
diff --git a/chrome/common/notification_details.h b/chrome/common/notification_details.h
index ee1011160c8b0adeaf2307def7ab7b642982b853..65f2b2b7fbfec19b0fbd07978aa13d18f209285b 100644
--- a/chrome/common/notification_details.h
+++ b/chrome/common/notification_details.h
@@ -33,7 +33,7 @@ class NotificationDetails {
}
protected:
- NotificationDetails(const void* ptr) : ptr_(ptr) {}
+ explicit NotificationDetails(const void* ptr) : ptr_(ptr) {}
// Declaring this const allows Details<T> to be used with both T = Foo and
// T = const Foo.
@@ -43,8 +43,8 @@ class NotificationDetails {
template <class T>
class Details : public NotificationDetails {
public:
- Details(T* ptr) : NotificationDetails(ptr) {}
- Details(const NotificationDetails& other)
+ explicit Details(T* ptr) : NotificationDetails(ptr) {}
+ explicit Details(const NotificationDetails& other)
: NotificationDetails(other) {}
T* operator->() const { return ptr(); }
« no previous file with comments | « chrome/common/net/socket_stream.h ('k') | chrome/common/notification_source.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698