Issue 384100: Revert 31814 - Testing to see if it caused performance problems....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 384100: Revert 31814 - Testing to see if it caused performance problems.... (Closed)

Created:
11 years, 1 month ago by dmac

Modified:
9 years, 7 months ago

Reviewers:
dmac, chase

CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 31814 - Testing to see if it caused performance problems. Add support for observing tracking areas so that when tabs are moved underneath our cursor, we highlight them correctly. BUG=27458, 13208, 21448 TEST=Create a pile of tabs. Select a middle one. Put your cursor in some other tab. Hit cmdw a couple of times Watch to make sure highlights occur correctly in both the tabs and the close buttons. Review URL: http://codereview.chromium.org/386021 TBR=dmaclach@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31856

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -71 lines)			Patch
	M	chrome/browser/cocoa/tab_strip_controller.mm	View		5 chunks	+3 lines, -49 lines	0 comments	Download
	M	chrome/browser/cocoa/tab_view.mm	View		1 chunk	+0 lines, -22 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

chase

11 years, 1 month ago (2009-11-13 00:22:18 UTC) #2

Dave, thanks for the speculative backout.  Mac10.5 warm startup perf returned to
levels before r31814 after this revert landed.  Assuming r31814 is the true
cause of the regression (as it appears to be), the total cost of the change in
terms of increase on the Mac warm startup perf was ~23ms, or around 7%.

Expand Messages | Collapse Messages