Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 384063004: Standardize persisted log loading (Closed)

Created:
6 years, 5 months ago by Steven Holte
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Standardize persisted log loading BUG=328417 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283329

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -21 lines) Patch
M components/metrics/metrics_service.cc View 1 2 8 chunks +13 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Steven Holte
6 years, 5 months ago (2014-07-14 17:36:14 UTC) #1
Alexei Svitkine (slow)
LGTM, thanks https://codereview.chromium.org/384063004/diff/20001/components/metrics/metrics_service.cc File components/metrics/metrics_service.cc (right): https://codereview.chromium.org/384063004/diff/20001/components/metrics/metrics_service.cc#newcode965 components/metrics/metrics_service.cc:965: static_cast<MetricsLog*>(log_manager_.current_log()); Nit: While you're here, you may ...
6 years, 5 months ago (2014-07-14 18:46:54 UTC) #2
Steven Holte
https://codereview.chromium.org/384063004/diff/20001/components/metrics/metrics_service.cc File components/metrics/metrics_service.cc (right): https://codereview.chromium.org/384063004/diff/20001/components/metrics/metrics_service.cc#newcode965 components/metrics/metrics_service.cc:965: static_cast<MetricsLog*>(log_manager_.current_log()); On 2014/07/14 18:46:54, Alexei Svitkine wrote: > Nit: ...
6 years, 5 months ago (2014-07-15 01:22:01 UTC) #3
Steven Holte
The CQ bit was checked by holte@chromium.org
6 years, 5 months ago (2014-07-15 01:24:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/holte@chromium.org/384063004/40001
6 years, 5 months ago (2014-07-15 01:26:08 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-15 19:32:24 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 04:20:31 UTC) #7
Message was sent while issue was closed.
Change committed as 283329

Powered by Google App Engine
This is Rietveld 408576698