Issue 384053003: Revert of Add support for NEON intrinsics to speed up texture compression. We can

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 384053003: Revert of Add support for NEON intrinsics to speed up texture compression. We can (Closed)

Created:
6 years, 5 months ago by krajcevski

Modified:
6 years, 5 months ago

Reviewers:
kevin.petit, mtklein, robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of Add support for NEON intrinsics to speed up texture compression. We can (https://codereview.chromium.org/390453002/) Reason for revert: Breaking chrome. Original issue's description: > Add support for NEON intrinsics to speed up texture compression. We can > now convert the time that we would have spent uploading the texture to > compressing it giving a net 50% memory savings for these things. > > Committed: https://skia.googlesource.com/skia/+/bc9205be0a1094e312da098348601398c210dc5a TBR=robertphillips@google.com,mtklein@google.com,kevin.petit@arm.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/d41dab43e612058c4f1c409e74869bded80e9d63

Created: 6 years, 5 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -341 lines)			Patch
M	gyp/opts.gyp	View	9 chunks	+0 lines, -9 lines	0 comments	Download
M	gyp/utils.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	src/opts/SkTextureCompression_opts.h	View	1 chunk	+0 lines, -17 lines	0 comments	Download
D	src/opts/SkTextureCompression_opts_neon.cpp	View	1 chunk	+0 lines, -258 lines	0 comments	Download
D	src/opts/SkTextureCompression_opts_none.cpp	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	src/utils/SkTextureCompressor.h	View	1 chunk	+1 line, -8 lines	0 comments	Download
M	src/utils/SkTextureCompressor.cpp	View	4 chunks	+21 lines, -35 lines	0 comments	Download

Total messages: 3 (0 generated)

krajcevski

Created Revert of Add support for NEON intrinsics to speed up texture compression. We can

6 years, 5 months ago (2014-07-11 20:14:32 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/384053003/1

6 years, 5 months ago (2014-07-11 20:15:09 UTC) #2

commit-bot: I haz the power

6 years, 5 months ago (2014-07-11 20:15:23 UTC) #3

Message was sent while issue was closed.

Change committed as d41dab43e612058c4f1c409e74869bded80e9d63