Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4949)

Unified Diff: chrome/browser/cocoa/bookmark_bar_controller.mm

Issue 384039: Mac: Use native folder icons for the bookmark bar. (Closed)
Patch Set: GRRRRRRRRAAAAAAAAAHHHHH Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/bookmark_bar_controller.mm
diff --git a/chrome/browser/cocoa/bookmark_bar_controller.mm b/chrome/browser/cocoa/bookmark_bar_controller.mm
index 142d669cd5f51588045a9be8c023021ef8afe843..1e01ab5f9cd9dd2d6f61233e1e53bbf6f2c4f70a 100644
--- a/chrome/browser/cocoa/bookmark_bar_controller.mm
+++ b/chrome/browser/cocoa/bookmark_bar_controller.mm
@@ -68,7 +68,8 @@
for (NSObject* item in itemsPendingBookmarkIcon_.get()) {
DCHECK([item respondsToSelector:@selector(setImage:)]);
- if ([item respondsToSelector:@selector(setImage:)]) {
+ if ([item retainCount] > 1 &&
+ [item respondsToSelector:@selector(setImage:)]) {
// |item| is not really of type |NSCell*|, but some type that responds to
// |setImage:| is required to shut up a compiler warning.
[(NSCell*)item setImage:folderImage_];
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698