Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 384023002: Rename "managed (mode|user)" to "supervised user" (part 6) (Closed)

Created:
6 years, 5 months ago by Marc Treib
Modified:
6 years, 5 months ago
CC:
chromium-reviews, tim+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, zea+watch_chromium.org, extensions-reviews_chromium.org, tfarina, haitaol+watch_chromium.org, dbeam+watch-options_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Rename "managed (mode|user)" to "supervised user" (part 6) Followup to https://codereview.chromium.org/350183002/ This CL renames (hopefully) all remaining C++/ObjC code apart from CrOS-specific code. It also renames a test data folder. Still missing: - ChromeOS-specific code in c/b/chromeos/login/managed/ and ash/system/ - JavaScript, HTML, CSS - The global ENABLE_MANAGED_USERS define TBR=msw@chromium.org (c/b/ui) TBR=atwilson@chromium.org (c/b/sync) The TBRs are simple renames. BUG=385113 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282962

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove binary changes #

Patch Set 3 : break long lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -930 lines) Patch
M WATCHLISTS View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/resources/managed_mode_block_interstitial.css View 1 chunk +0 lines, -84 lines 0 comments Download
D chrome/browser/resources/managed_mode_block_interstitial.html View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/browser/resources/managed_mode_block_interstitial.js View 1 chunk +0 lines, -34 lines 0 comments Download
A + chrome/browser/resources/supervised_user_block_interstitial.css View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
A + chrome/browser/resources/supervised_user_block_interstitial.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/resources/supervised_user_block_interstitial.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/sync/test/integration/single_client_managed_user_settings_sync_test.cc View 1 chunk +0 lines, -56 lines 0 comments Download
A + chrome/browser/sync/test/integration/single_client_supervised_user_settings_sync_test.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_icon_controller.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_menu_bubble_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/avatar_menu_button.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/create_profile_handler.h View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/webui/options/managed_user_create_confirm_handler.h View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/browser/ui/webui/options/managed_user_create_confirm_handler.cc View 1 chunk +0 lines, -91 lines 0 comments Download
D chrome/browser/ui/webui/options/managed_user_import_handler.h View 1 chunk +0 lines, -96 lines 0 comments Download
D chrome/browser/ui/webui/options/managed_user_import_handler.cc View 1 chunk +0 lines, -251 lines 0 comments Download
D chrome/browser/ui/webui/options/managed_user_learn_more_handler.h View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/ui/webui/options/managed_user_learn_more_handler.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M chrome/browser/ui/webui/options/options_ui.cc View 2 chunks +8 lines, -7 lines 0 comments Download
A + chrome/browser/ui/webui/options/supervised_user_create_confirm_handler.h View 3 chunks +8 lines, -8 lines 0 comments Download
A + chrome/browser/ui/webui/options/supervised_user_create_confirm_handler.cc View 3 chunks +7 lines, -7 lines 0 comments Download
A + chrome/browser/ui/webui/options/supervised_user_import_handler.h View 3 chunks +28 lines, -28 lines 0 comments Download
A + chrome/browser/ui/webui/options/supervised_user_import_handler.cc View 8 chunks +24 lines, -23 lines 0 comments Download
A + chrome/browser/ui/webui/options/supervised_user_learn_more_handler.h View 2 chunks +8 lines, -8 lines 0 comments Download
A + chrome/browser/ui/webui/options/supervised_user_learn_more_handler.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
D chrome/test/data/extensions/managed_mode/content_pack/manifest.json View 1 chunk +0 lines, -8 lines 0 comments Download
D chrome/test/data/extensions/managed_mode/content_pack/site_list.json View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/test/data/extensions/managed_mode/content_pack_2/manifest.json View 1 chunk +0 lines, -8 lines 0 comments Download
D chrome/test/data/extensions/managed_mode/content_pack_2/site_list.json View 1 chunk +0 lines, -11 lines 0 comments Download
A + chrome/test/data/extensions/supervised_user/content_pack/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/supervised_user/content_pack/site_list.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/supervised_user/content_pack_2/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/supervised_user/content_pack_2/site_list.json View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Marc Treib
Hi Pam and Bernhard, can either of you PTAL? The bot failures are due to ...
6 years, 5 months ago (2014-07-11 16:14:16 UTC) #1
Bernhard Bauer
lgtm
6 years, 5 months ago (2014-07-11 16:19:30 UTC) #2
Pam (message me for reviews)
LGTM2 https://codereview.chromium.org/384023002/diff/1/chrome/browser/ui/webui/options/create_profile_handler.h File chrome/browser/ui/webui/options/create_profile_handler.h (right): https://codereview.chromium.org/384023002/diff/1/chrome/browser/ui/webui/options/create_profile_handler.h#newcode93 chrome/browser/ui/webui/options/create_profile_handler.h:93: // After a new supervised user profile has ...
6 years, 5 months ago (2014-07-11 17:36:21 UTC) #3
Marc Treib
https://codereview.chromium.org/384023002/diff/1/chrome/browser/ui/webui/options/create_profile_handler.h File chrome/browser/ui/webui/options/create_profile_handler.h (right): https://codereview.chromium.org/384023002/diff/1/chrome/browser/ui/webui/options/create_profile_handler.h#newcode93 chrome/browser/ui/webui/options/create_profile_handler.h:93: // After a new supervised user profile has been ...
6 years, 5 months ago (2014-07-14 08:18:15 UTC) #4
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 5 months ago (2014-07-14 09:59:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/384023002/210001
6 years, 5 months ago (2014-07-14 10:00:19 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-14 14:07:26 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-14 14:10:31 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/79737)
6 years, 5 months ago (2014-07-14 14:10:33 UTC) #9
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 5 months ago (2014-07-14 14:48:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/384023002/230001
6 years, 5 months ago (2014-07-14 14:48:58 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 16:39:39 UTC) #12
Message was sent while issue was closed.
Change committed as 282962

Powered by Google App Engine
This is Rietveld 408576698