Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Side by Side Diff: src/regexp.js

Issue 384003003: Replace AddProperty by AddNamedProperty to speed up the common case (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/promise.js ('k') | src/runtime.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file relies on the fact that the following declaration has been made 5 // This file relies on the fact that the following declaration has been made
6 // in runtime.js: 6 // in runtime.js:
7 // var $Object = global.Object; 7 // var $Object = global.Object;
8 // var $Array = global.Array; 8 // var $Array = global.Array;
9 9
10 var $RegExp = global.RegExp; 10 var $RegExp = global.RegExp;
(...skipping 363 matching lines...) Expand 10 before | Expand all | Expand 10 after
374 // Used internally by replace regexp with function. 374 // Used internally by replace regexp with function.
375 // The array has the format of an "apply" argument for a replacement 375 // The array has the format of an "apply" argument for a replacement
376 // function. 376 // function.
377 var lastMatchInfoOverride = null; 377 var lastMatchInfoOverride = null;
378 378
379 // ------------------------------------------------------------------- 379 // -------------------------------------------------------------------
380 380
381 function SetUpRegExp() { 381 function SetUpRegExp() {
382 %CheckIsBootstrapping(); 382 %CheckIsBootstrapping();
383 %FunctionSetInstanceClassName($RegExp, 'RegExp'); 383 %FunctionSetInstanceClassName($RegExp, 'RegExp');
384 %AddProperty($RegExp.prototype, 'constructor', $RegExp, DONT_ENUM); 384 %AddNamedProperty($RegExp.prototype, 'constructor', $RegExp, DONT_ENUM);
385 %SetCode($RegExp, RegExpConstructor); 385 %SetCode($RegExp, RegExpConstructor);
386 386
387 InstallFunctions($RegExp.prototype, DONT_ENUM, $Array( 387 InstallFunctions($RegExp.prototype, DONT_ENUM, $Array(
388 "exec", RegExpExec, 388 "exec", RegExpExec,
389 "test", RegExpTest, 389 "test", RegExpTest,
390 "toString", RegExpToString, 390 "toString", RegExpToString,
391 "compile", RegExpCompileJS 391 "compile", RegExpCompileJS
392 )); 392 ));
393 393
394 // The length of compile is 1 in SpiderMonkey. 394 // The length of compile is 1 in SpiderMonkey.
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
457 457
458 for (var i = 1; i < 10; ++i) { 458 for (var i = 1; i < 10; ++i) {
459 %DefineAccessorPropertyUnchecked($RegExp, '$' + i, 459 %DefineAccessorPropertyUnchecked($RegExp, '$' + i,
460 RegExpMakeCaptureGetter(i), NoOpSetter, 460 RegExpMakeCaptureGetter(i), NoOpSetter,
461 DONT_DELETE); 461 DONT_DELETE);
462 } 462 }
463 %ToFastProperties($RegExp); 463 %ToFastProperties($RegExp);
464 } 464 }
465 465
466 SetUpRegExp(); 466 SetUpRegExp();
OLDNEW
« no previous file with comments | « src/promise.js ('k') | src/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698