Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 384003003: Replace AddProperty by AddNamedProperty to speed up the common case (Closed)

Created:
6 years, 5 months ago by Toon Verwaest
Modified:
6 years, 5 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Replace AddProperty by AddNamedProperty to speed up the common case BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22381

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+325 lines, -338 lines) Patch
M src/array.js View 1 chunk +1 line, -1 line 0 comments Download
M src/array-iterator.js View 3 chunks +7 lines, -7 lines 0 comments Download
M src/arraybuffer.js View 1 chunk +2 lines, -1 line 0 comments Download
M src/collection.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/collection-iterator.js View 4 chunks +4 lines, -4 lines 0 comments Download
M src/date.js View 1 chunk +1 line, -1 line 0 comments Download
M src/generator.js View 1 chunk +3 lines, -3 lines 0 comments Download
M src/i18n.js View 12 chunks +14 lines, -12 lines 0 comments Download
M src/math.js View 1 chunk +1 line, -1 line 0 comments Download
M src/messages.js View 4 chunks +10 lines, -10 lines 0 comments Download
M src/object-observe.js View 1 chunk +2 lines, -1 line 0 comments Download
M src/promise.js View 1 chunk +1 line, -1 line 0 comments Download
M src/regexp.js View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.h View 1 chunk +217 lines, -217 lines 0 comments Download
M src/runtime.cc View 2 chunks +7 lines, -17 lines 0 comments Download
M src/string.js View 1 chunk +1 line, -1 line 0 comments Download
M src/string-iterator.js View 2 chunks +4 lines, -4 lines 0 comments Download
M src/symbol.js View 1 chunk +1 line, -1 line 0 comments Download
M src/typedarray.js View 2 chunks +8 lines, -8 lines 0 comments Download
M src/v8natives.js View 9 chunks +18 lines, -17 lines 0 comments Download
M src/weak_collection.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-1199637.js View 1 chunk +8 lines, -8 lines 0 comments Download
M test/mjsunit/regress/regress-334.js View 1 chunk +4 lines, -4 lines 0 comments Download
M test/mjsunit/regress/regress-cntl-descriptors-enum.js View 1 chunk +2 lines, -2 lines 0 comments Download
A + test/mjsunit/runtime-gen/addnamedproperty.js View 1 chunk +2 lines, -2 lines 0 comments Download
D test/mjsunit/runtime-gen/addproperty.js View 1 chunk +0 lines, -8 lines 0 comments Download
M tools/generate-runtime-tests.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
PTAL
6 years, 5 months ago (2014-07-14 09:35:10 UTC) #1
Toon Verwaest
PTAL
6 years, 5 months ago (2014-07-14 09:35:12 UTC) #2
Igor Sheludko
lgtm
6 years, 5 months ago (2014-07-14 11:44:20 UTC) #3
Toon Verwaest
6 years, 5 months ago (2014-07-14 14:05:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r22381 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698