Moved the version number in App Info Dialog

chrome/browser/ui/views/apps/app_info_dialog/app_info_panel.h

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_panel.h
diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_panel.h b/chrome/browser/ui/views/apps/app_info_dialog/app_info_panel.h
index 2545e6b282086c4786adecdcf5a5bbd2bc424f32..cf280336c6585d46f0ac82100068569f061db80c 100644
--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_panel.h
+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_panel.h
@@ -28,10 +28,21 @@ class AppInfoPanel : public views::View {
   // Create a heading label with the given text.
   views::Label* CreateHeading(const base::string16& text) const;
 
+  // Create a left-aligned label with the given text.
+  views::Label* CreateLeftAlignedLabel(const base::string16& text) const;

[Matt Giuca, 2014/07/14 01:57:23]

I don't think this is a worthwhile abstraction -- it's only used four times and
only saves 1 line of code each time, but it means you force the reader to go and
track down this function. I suggest you just remove it.

(As opposed to CreateHeading, which I think is useful, because it doesn't just
do exactly what its title says; its title is semantic and it makes styling
decisions that *should* be abstracted.)

[sashab, 2014/07/14 23:19:20]

Agreed. Done.

+
   // Create a view with a vertically-stacked box layout, which can have child
-  // views appended to it.
+  // views appended to it. |child_spacing| defaults to the spacing between

[Matt Giuca, 2014/07/14 01:57:22]

This new comment doesn't really make sense. Maybe just say:
|child_spacing| defaults to |views::kRelatedControlVerticalSpacing|.
or
|child_spacing| defaults to a reasonable value.

[sashab, 2014/07/14 23:19:20]

Done.

+  // related vertical controls.
+  views::View* CreateVerticalStack(int child_spacing) const;
   views::View* CreateVerticalStack() const;
 
+  // Create a view with a horizontally-stacked box layout, which can have child
+  // views appended to it. |child_spacing| defaults to the spacing between
+  // related horizontal controls.
+  views::View* CreateHorizontalStack(int child_spacing) const;
+  views::View* CreateHorizontalStack() const;
+
   Profile* profile_;
   const extensions::Extension* app_;