Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3129)

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.h

Issue 383953002: Moved the version number in App Info Dialog (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Minor changes Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.h
diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.h b/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.h
index da17ffc22324eba97d56a9e7fbbeebcd8fd6ef47..2b26d772326c4dfa767e7fce86a869f1fd3bb6df 100644
--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.h
+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.h
@@ -34,12 +34,18 @@ class AppInfoSummaryPanel : public AppInfoPanel,
private:
// Internal initialisation methods.
void CreateDescriptionControl();
+ void CreateDetailsControl();
void CreateLaunchOptionControl();
+
void LayoutDescriptionControl();
+ void LayoutDetailsControl();
// Overridden from views::ComboboxListener:
virtual void OnPerformAction(views::Combobox* combobox) OVERRIDE;
+ // Returns true if the app has a version number that makes sense to display.
+ bool HasVersion() const;
+
// Returns the launch type of the app (e.g. pinned tab, fullscreen, etc).
extensions::LaunchType GetLaunchType() const;
@@ -52,6 +58,10 @@ class AppInfoSummaryPanel : public AppInfoPanel,
views::Label* description_heading_;
views::Label* description_label_;
+ views::Label* details_heading_;
+ views::Label* version_title_;
+ views::Label* version_value_;
+
scoped_ptr<LaunchOptionsComboboxModel> launch_options_combobox_model_;
views::Combobox* launch_options_combobox_;

Powered by Google App Engine
This is Rietveld 408576698