Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 383933003: Add option to output device status to a JSON file. (Closed)

Created:
6 years, 5 months ago by zty
Modified:
6 years, 5 months ago
Reviewers:
navabi1, tonyg, navabi
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : Added more fields to JSON output. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M build/android/buildbot/bb_device_status_check.py View 1 3 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
zty
ptal
6 years, 5 months ago (2014-07-11 01:20:52 UTC) #1
tonyg
https://codereview.chromium.org/383933003/diff/1/build/android/buildbot/bb_device_status_check.py File build/android/buildbot/bb_device_status_check.py (right): https://codereview.chromium.org/383933003/diff/1/build/android/buildbot/bb_device_status_check.py#newcode280 build/android/buildbot/bb_device_status_check.py:280: help='Output JSON information into a specified file.') We should ...
6 years, 5 months ago (2014-07-11 02:19:16 UTC) #2
zty
https://codereview.chromium.org/383933003/diff/1/build/android/buildbot/bb_device_status_check.py File build/android/buildbot/bb_device_status_check.py (right): https://codereview.chromium.org/383933003/diff/1/build/android/buildbot/bb_device_status_check.py#newcode368 build/android/buildbot/bb_device_status_check.py:368: 'online_devices': devices, On 2014/07/11 02:19:15, tonyg wrote: > Let's ...
6 years, 5 months ago (2014-07-11 18:58:30 UTC) #3
navabi
lgtm
6 years, 5 months ago (2014-07-11 19:08:26 UTC) #4
tonyg
lgtm
6 years, 5 months ago (2014-07-11 20:04:51 UTC) #5
zty
The CQ bit was checked by zty@chromium.org
6 years, 5 months ago (2014-07-11 20:35:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zty@chromium.org/383933003/20001
6 years, 5 months ago (2014-07-11 20:36:56 UTC) #7
navabi1
lgtm
6 years, 5 months ago (2014-07-11 21:11:03 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 23:20:48 UTC) #9
Message was sent while issue was closed.
Change committed as 282728

Powered by Google App Engine
This is Rietveld 408576698