Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 383903003: ifdef various extensions code to be used only when extensions are enabled. (Closed)

Created:
6 years, 5 months ago by Lei Zhang
Modified:
6 years, 5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, miu+watch_chromium.org, posciak+watch_chromium.org, James Su, wjia+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

ifdef various extensions code to be used only when extensions are enabled. BUG=349436 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282806

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -42 lines) Patch
M chrome/browser/autocomplete/autocomplete_classifier_factory.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/media/media_stream_capture_indicator.cc View 7 chunks +11 lines, -8 lines 0 comments Download
M chrome/browser/memory_details.cc View 1 2 10 chunks +34 lines, -19 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 6 chunks +19 lines, -11 lines 0 comments Download
M chrome/browser/prefs/chrome_pref_service_factory.cc View 6 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/ui/tab_helpers.cc View 1 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Lei Zhang
6 years, 5 months ago (2014-07-11 00:14:36 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-11 09:23:24 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 5 months ago (2014-07-11 19:31:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/383903003/1
6 years, 5 months ago (2014-07-11 19:33:03 UTC) #4
Lei Zhang
The CQ bit was unchecked by thestig@chromium.org
6 years, 5 months ago (2014-07-11 20:35:06 UTC) #5
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 5 months ago (2014-07-12 01:50:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/383903003/30001
6 years, 5 months ago (2014-07-12 01:51:20 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-12 03:28:27 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-12 06:19:01 UTC) #9
Message was sent while issue was closed.
Change committed as 282806

Powered by Google App Engine
This is Rietveld 408576698