Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: tools/bisect-builds.py

Issue 383903002: Convert githash to chromium revision instead of blink revision while doing a blink bisect (with -l … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bisect-builds.py
diff --git a/tools/bisect-builds.py b/tools/bisect-builds.py
index e1f5e03f9f6caba9fd774d7f6fba4f7298e17f03..b8b1b6a694acccf8235f03b3754ee5800a902ec8 100755
--- a/tools/bisect-builds.py
+++ b/tools/bisect-builds.py
@@ -199,14 +199,6 @@ class PathContext(object):
next-marker is not None, then the listing is a partial listing and another
fetch should be performed with next-marker being the marker= GET
parameter."""
- def _GetDepotName():
- if self.base_url == CHROMIUM_BASE_URL:
- return 'chromium'
- elif self.base_url == WEBKIT_BASE_URL:
- return 'blink'
- else:
- return 'chromium'
-
handle = urllib.urlopen(url)
document = ElementTree.parse(handle)
@@ -238,7 +230,7 @@ class PathContext(object):
try:
if not revnum.isdigit():
git_hash = revnum
- revnum = self.GetSVNRevisionFromGitHash(git_hash, _GetDepotName())
+ revnum = self.GetSVNRevisionFromGitHash(git_hash)
githash_svn_dict[revnum] = git_hash
if revnum is not None:
revnum = int(revnum)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698