Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 383903002: Convert githash to chromium revision instead of blink revision while doing a blink bisect (with -l … (Closed)

Created:
6 years, 5 months ago by pshenoy
Modified:
6 years, 5 months ago
Reviewers:
Robert Sesek, kareng, karen
CC:
chromium-reviews, anantha
Project:
chromium
Visibility:
Public.

Description

Convert githash to chromium revision instead of blink revision while doing a blink bisect (with -l option) in _FetchAndParse.Even though we are doing the blink bisect http://commondatastorage.googleapis.com/chromium-webkit-snapshots/index.html still stores the builds by chromium revisions. BUG=None NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282635

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M tools/bisect-builds.py View 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
pshenoy
Hi Karen, Looks like Robert is on OOO this week. Can you please take a ...
6 years, 5 months ago (2014-07-10 23:15:07 UTC) #1
kareng
On 2014/07/10 23:15:07, pshenoy wrote: > Hi Karen, Looks like Robert is on OOO this ...
6 years, 5 months ago (2014-07-11 16:30:02 UTC) #2
pshenoy
The CQ bit was checked by pshenoy@chromium.org
6 years, 5 months ago (2014-07-11 16:31:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pshenoy@chromium.org/383903002/1
6 years, 5 months ago (2014-07-11 16:32:52 UTC) #4
commit-bot: I haz the power
Change committed as 282635
6 years, 5 months ago (2014-07-11 16:34:40 UTC) #5
Robert Sesek
LGTM In the future, I'd recommend hard wrapping your CL descriptions to ~80 columns so ...
6 years, 5 months ago (2014-07-14 14:07:29 UTC) #6
pshenoy
6 years, 5 months ago (2014-07-14 16:25:44 UTC) #7
Message was sent while issue was closed.
On 2014/07/14 14:07:29, rsesek wrote:
> LGTM
> 
> In the future, I'd recommend hard wrapping your CL descriptions to ~80 columns
> so that it's easier to read in `git log` output.

Sure. Thank you.

Powered by Google App Engine
This is Rietveld 408576698