Issue 383813002: Enable tools/CrashHandler again.

Issue 383813002: Enable tools/CrashHandler again. (Closed)

Created:
6 years, 5 months ago by mtklein_C

Modified:
6 years, 5 months ago

Reviewers:
borenet, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Enable tools/CrashHandler again. - Defaults to on the bots, triggered off CHROME_HEADLESS=1 in the environment. - Defaults off otherwise. - Can be enabled by setting CHROME_HEADLESS=1 (weird) or GYP_DEFINES=skia_crash_handler=1. BUG=skia: Committed: https://skia.googlesource.com/skia/+/4d1605a8d64792c03e3a93178d51ad6d23fc5ea6

Patch Set 1 #

Total comments: 2

Patch Set 2 : error #

Patch Set 3 : debug #

Patch Set 4 : Eric #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	gyp/common_conditions.gypi	View	3	1 chunk	+4 lines, -0 lines	0 comments	Download
	M	gyp/common_variables.gypi	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

borenet

LGTM if Windows passes... otherwise you may have to do some goofy Python thing: 'skia_crash_handler%': ...

6 years, 5 months ago (2014-07-10 19:58:29 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/383813002/40002

6 years, 5 months ago (2014-07-10 20:56:22 UTC) #4

mtklein

https://codereview.chromium.org/383813002/diff/1/gyp/common_variables.gypi File gyp/common_variables.gypi (right): https://codereview.chromium.org/383813002/diff/1/gyp/common_variables.gypi#newcode229 gyp/common_variables.gypi:229: 'skia_crash_handler%': '<!(echo $CHROME_HEADLESS)', On 2014/07/10 19:58:29, borenet wrote: > ...

6 years, 5 months ago (2014-07-10 20:57:39 UTC) #5

commit-bot: I haz the power

Change committed as 4d1605a8d64792c03e3a93178d51ad6d23fc5ea6

6 years, 5 months ago (2014-07-10 21:16:09 UTC) #6

reed1

6 years, 5 months ago (2014-07-10 21:28:08 UTC) #7

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/382053002/ by reed@google.com.

The reason for reverting is: broke mac 10.6.

Expand Messages | Collapse Messages