Issue 383793002: [Telemetry] Fix a few more potential deadlocks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 383793002: [Telemetry] Fix a few more potential deadlocks. (Closed)

Created:
6 years, 5 months ago by tonyg

Modified:
6 years, 5 months ago

Reviewers:
jbudorick

CC:
chromium-reviews, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Telemetry] Fix a few more potential deadlocks. This builds on https://codereview.chromium.org/385653002/ . Many functions in Python's logging module grab a lock internally. Some appear to do so before converting the provided message to a string via its __str__ method. Calling an object's __str__ method before calling a logging funciton allows anything called by the __str__ method to log without the risk of hitting a deadlock. BUG=392869 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282485

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -4 lines)			Patch
M	tools/telemetry/telemetry/benchmark.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/core/platform/linux_platform_backend.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/383793002/1

6 years, 5 months ago (2014-07-10 18:19:41 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...

6 years, 5 months ago (2014-07-10 22:23:35 UTC) #5

Message was sent while issue was closed.

Change committed as 282485

Expand Messages | Collapse Messages