Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 383763003: Trigger Node destruction notifications from Node's dtor (Closed)

Created:
6 years, 5 months ago by Ben Goodger (Google)
Modified:
6 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Trigger Node destruction notifications from Node's dtor R=sky@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282403

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -82 lines) Patch
M mojo/services/view_manager/node.cc View 1 2 2 chunks +13 lines, -2 lines 0 comments Download
M mojo/services/view_manager/node_delegate.h View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.h View 4 chunks +4 lines, -2 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.cc View 4 chunks +13 lines, -8 lines 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.h View 4 chunks +3 lines, -17 lines 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.cc View 1 2 3 5 chunks +7 lines, -51 lines 0 comments Download
M mojo/services/view_manager/view_manager_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
6 years, 5 months ago (2014-07-10 18:22:24 UTC) #1
sky
LGTM
6 years, 5 months ago (2014-07-10 19:08:34 UTC) #2
Ben Goodger (Google)
6 years, 5 months ago (2014-07-10 19:58:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r282403 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698