Source/platform/heap/Profiling.h - Issue 383743002: Oilpan: GC profiling.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/platform/heap/Profiling.h

Issue 383743002: Oilpan: GC profiling. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: TracedValue contexts Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef Profiling_h

	6 #define Profiling_h

	7

	8 // Name for about:tracing events

	9 #define GC_PROFILE_GROUP "BlinkGC"
	haraken 2014/07/14 02:26:14 "BlinkGC" => "blinkGC" (due to a convention of tra "BlinkGC" => "blinkGC" (due to a convention of trace event names) Also we normally hard-code the name when using trace event macros. zerny-chromium 2014/07/28 11:54:41 Done, but kept the macro so we avoid search-replac Show quoted text On 2014/07/14 02:26:14, haraken wrote: > > "BlinkGC" => "blinkGC" (due to a convention of trace event names) > > Also we normally hard-code the name when using trace event macros. Done, but kept the macro so we avoid search-replace on a string key for a const name that will likely change again.
	10

	11 // Extended profiling of memory usage.

	12 #define GC_PROFILE_HEAP ENABLE(GC_PROFILING_HEAP)
	haraken 2014/07/14 02:26:14 Blink normally doesn't use this kind of re-define. Blink normally doesn't use this kind of re-define. Shall we use ENABLE(GC_PROFILING_HEAP) as is? zerny-chromium 2014/07/28 11:54:41 I can do that. The reasoning for having the two di Show quoted text On 2014/07/14 02:26:14, haraken wrote: > > Blink normally doesn't use this kind of re-define. Shall we use > ENABLE(GC_PROFILING_HEAP) as is? > I can do that. The reasoning for having the two distinct types was that we can more easily split the GC_PROFILE_HEAP into several sub #defs (such as _FAST and _SLOW) independent of the GYP flag/naming. Should I change it or keep it? haraken 2014/07/28 17:45:47 If the split does really matter, I'm OK with intro Show quoted text On 2014/07/28 11:54:41, zerny-chromium wrote: > On 2014/07/14 02:26:14, haraken wrote: > > > > Blink normally doesn't use this kind of re-define. Shall we use > > ENABLE(GC_PROFILING_HEAP) as is? > > > > I can do that. The reasoning for having the two distinct types was that we can > more easily split the GC_PROFILE_HEAP into several sub #defs (such as _FAST and > _SLOW) independent of the GYP flag/naming. Should I change it or keep it? If the split does really matter, I'm OK with introducing GC_PROFILE_HEAP. However, otherwise I'd prefer just using ENABLE(GC_PROFILING_HEAP), following other Blink code base. I guess it's important to follow existing conventions. Actually I hope this file is gone since this file is just redefining macros.
	13 #define GC_PROFILE_HEAP_PAGE_DUMP_THRESHOLD 0

	14

	15 // Extended profiling of GC marking/tracing

	16 #define GC_PROFILE_MARKING ENABLE(GC_PROFILING_MARKING)
	haraken 2014/07/14 02:26:14 Ditto. Ditto.
	17

	18 // Dependencies for several profiling usages.

	19 #define GC_PROFILE_DEFINE_CLASSNAME (GC_PROFILE_HEAP \|\| GC_PROFILE_MARKING)

	20

	21 #endif

OLD	NEW

« Source/platform/heap/Heap.cpp ('K') | « Source/platform/heap/HeapTest.cpp ('k') | Source/platform/heap/ThreadState.h » ('j') | Source/platform/heap/ThreadState.h » ('J')