Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 383733002: Split SkPictureReplacementPlayback out of SkPicturePlayback (Closed)

Created:
6 years, 5 months ago by robertphillips
Modified:
6 years, 5 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Split SkPictureReplacementPlayback out of SkPicturePlayback Committed: https://skia.googlesource.com/skia/+/c26d991bf2d85bb1843a21b0a4f861212b0eaced

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -177 lines) Patch
M gyp/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M include/core/SkPicture.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkPicturePlayback.h View 3 chunks +6 lines, -53 lines 0 comments Download
M src/core/SkPicturePlayback.cpp View 3 chunks +0 lines, -119 lines 0 comments Download
M src/core/SkPictureRangePlayback.h View 1 chunk +1 line, -0 lines 0 comments Download
A src/core/SkPictureReplacementPlayback.h View 1 1 chunk +86 lines, -0 lines 0 comments Download
A src/core/SkPictureReplacementPlayback.cpp View 1 chunk +171 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 4 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
robertphillips
6 years, 5 months ago (2014-07-10 13:38:12 UTC) #1
mtklein
lgtm https://codereview.chromium.org/383733002/diff/1/src/core/SkPictureReplacementPlayback.cpp File src/core/SkPictureReplacementPlayback.cpp (right): https://codereview.chromium.org/383733002/diff/1/src/core/SkPictureReplacementPlayback.cpp#newcode57 src/core/SkPictureReplacementPlayback.cpp:57: bool SkPictureReplacementPlayback::replaceOps(SkPictureStateTree::Iterator* iter, Can you add a comment ...
6 years, 5 months ago (2014-07-10 13:47:06 UTC) #2
robertphillips
https://codereview.chromium.org/383733002/diff/1/src/core/SkPictureReplacementPlayback.cpp File src/core/SkPictureReplacementPlayback.cpp (right): https://codereview.chromium.org/383733002/diff/1/src/core/SkPictureReplacementPlayback.cpp#newcode57 src/core/SkPictureReplacementPlayback.cpp:57: bool SkPictureReplacementPlayback::replaceOps(SkPictureStateTree::Iterator* iter, On 2014/07/10 13:47:06, mtklein wrote: > ...
6 years, 5 months ago (2014-07-10 14:04:19 UTC) #3
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 5 months ago (2014-07-10 14:04:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/383733002/20001
6 years, 5 months ago (2014-07-10 14:05:25 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-10 14:05:29 UTC) #6
commit-bot: I haz the power
Presubmit check for 383733002-20001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 5 months ago (2014-07-10 14:05:30 UTC) #7
reed1
lgtm
6 years, 5 months ago (2014-07-10 14:06:43 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 14:21:33 UTC) #9
Message was sent while issue was closed. 
Change committed as c26d991bf2d85bb1843a21b0a4f861212b0eaced

Powered by Google App Engine
This is Rietveld 408576698