Clear the ephemeral app cache from Clear Browsing Data

chrome/browser/apps/ephemeral_app_service_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "chrome/browser/apps/ephemeral_app_browsertest.h"
 #include "chrome/browser/apps/ephemeral_app_service.h"
-#include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "content/public/test/test_utils.h"
 #include "extensions/browser/extension_prefs.h"
-#include "extensions/browser/extension_system.h"
+#include "extensions/browser/extension_registry.h"
 #include "extensions/common/manifest.h"
 
 using extensions::Extension;
 using extensions::ExtensionPrefs;
-using extensions::ExtensionSystem;
+using extensions::ExtensionRegistry;
 
 namespace {
 
 const int kNumTestApps = 2;
 const char* kTestApps[] = {
   "app_window/generic",
   "minimal"
 };
 
 }  // namespace
@@ skipping 53 matching lines @@
       base::TimeDelta::FromDays(EphemeralAppService::kAppKeepThreshold);
   prefs->SetLastLaunchTime(active_app_id, active_launch);
 
   // Perform garbage collection.
   content::WindowedNotificationObserver uninstall_signal(
       chrome::NOTIFICATION_EXTENSION_UNINSTALLED_DEPRECATED,
       content::Source<Profile>(browser()->profile()));
   GarbageCollectEphemeralApps();
   uninstall_signal.Wait();
 
-  ExtensionService* service = ExtensionSystem::Get(browser()->profile())
-      ->extension_service();
-  ASSERT_TRUE(service);
-  EXPECT_FALSE(service->GetInstalledExtension(inactive_app_id));
-  EXPECT_TRUE(service->GetInstalledExtension(active_app_id));
+  ExtensionRegistry* registry = ExtensionRegistry::Get(profile());
+  ASSERT_TRUE(registry);
+  EXPECT_FALSE(registry->GetExtensionById(inactive_app_id,
+                                          ExtensionRegistry::EVERYTHING));
+  EXPECT_TRUE(
+      registry->GetExtensionById(active_app_id, ExtensionRegistry::EVERYTHING));
 
   EXPECT_EQ(1, ephemeral_service->ephemeral_app_count());
 }
 
 // Verify that the count of ephemeral apps is maintained correctly.
-IN_PROC_BROWSER_TEST_F(EphemeralAppServiceBrowserTest,
-                       EphemeralAppCount) {
+IN_PROC_BROWSER_TEST_F(EphemeralAppServiceBrowserTest, EphemeralAppCount) {
   EphemeralAppService* ephemeral_service =
       EphemeralAppService::Get(browser()->profile());
   ASSERT_TRUE(ephemeral_service);
   InitEphemeralAppCount(ephemeral_service);
 
   // The count should not increase for regular installed apps.
   EXPECT_TRUE(InstallPlatformApp("minimal"));
   EXPECT_EQ(0, ephemeral_service->ephemeral_app_count());
 
   // The count should increase when an ephemeral app is added.
   const Extension* app = InstallEphemeralApp(kMessagingReceiverApp);
   ASSERT_TRUE(app);
   EXPECT_EQ(1, ephemeral_service->ephemeral_app_count());
 
   // The count should remain constant if the ephemeral app is updated.
   const std::string app_id = app->id();
   app = UpdateEphemeralApp(
       app_id, GetTestPath(kMessagingReceiverAppV2),
       GetTestPath(kMessagingReceiverApp).ReplaceExtension(
           FILE_PATH_LITERAL(".pem")));
   ASSERT_TRUE(app);
   EXPECT_EQ(1, ephemeral_service->ephemeral_app_count());
 
   // The count should decrease when an ephemeral app is promoted to a regular
   // installed app.
   PromoteEphemeralApp(app);
   EXPECT_EQ(0, ephemeral_service->ephemeral_app_count());
 }
+
+// Verify that the cache of ephemeral apps is correctly cleared. Running apps
+// should not be removed.
+IN_PROC_BROWSER_TEST_F(EphemeralAppServiceBrowserTest, ClearCachedApps) {
+  const Extension* running_app =
+      InstallAndLaunchEphemeralApp(kMessagingReceiverApp);
+  const Extension* inactive_app =
+      InstallAndLaunchEphemeralApp(kDispatchEventTestApp);
+  std::string inactive_app_id = inactive_app->id();
+  std::string running_app_id = running_app->id();
+  CloseApp(inactive_app_id);
+
+  EphemeralAppService* ephemeral_service =
+      EphemeralAppService::Get(browser()->profile());
+  ASSERT_TRUE(ephemeral_service);
+  EXPECT_EQ(2, ephemeral_service->ephemeral_app_count());
+
+  ephemeral_service->ClearCachedApps();
+
+  ExtensionRegistry* registry = ExtensionRegistry::Get(profile());
+  ASSERT_TRUE(registry);
+  EXPECT_FALSE(registry->GetExtensionById(inactive_app_id,
+                                          ExtensionRegistry::EVERYTHING));
+  EXPECT_TRUE(registry->GetExtensionById(running_app_id,
+                                         ExtensionRegistry::EVERYTHING));
+
+  EXPECT_EQ(1, ephemeral_service->ephemeral_app_count());
+}