Issue 383693002: Revert 282212 "Retrieve "connected" property from BLE devices."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 383693002: Revert 282212 "Retrieve "connected" property from BLE devices." (Closed)

Created:
6 years, 5 months ago by horo

Modified:
6 years, 5 months ago

Reviewers:
rpaquay

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 282212 "Retrieve "connected" property from BLE devices." Tests on XP are failing. http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%282%29/builds/34594 http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%282%29 We should use LoadLibrary and GetProcAddress to call SetupDIGetDeviceProperty because it is not available in WinXP. > Retrieve "connected" property from BLE devices. > > We have to use the SetupDIGetDeviceProperty API to retrieve this specific property, as the "connected" status is something common to many PnP devices. > > BUG=388016 > > Review URL: https://codereview.chromium.org/379943003 TBR=rpaquay@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282295

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -144 lines)			Patch
M	trunk/src/device/bluetooth/bluetooth_low_energy_win.h	View	2 chunks	+2 lines, -28 lines	0 comments	Download
M	trunk/src/device/bluetooth/bluetooth_low_energy_win.cc	View	12 chunks	+6 lines, -104 lines	0 comments	Download
M	trunk/src/device/bluetooth/bluetooth_low_energy_win_unittest.cc	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	trunk/src/device/bluetooth/bluetooth_task_manager_win.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

horo

6 years, 5 months ago (2014-07-10 09:45:20 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r282295 (tree was closed).