chrome/browser/ui/webui/print_preview/print_preview_ui.h - Issue 383623002: Add a browser test that can communicate with the layout test framework and print pdfs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_ui.h

Issue 383623002: Add a browser test that can communicate with the layout test framework and print pdfs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed typos, added overflow detection, rewrote poorly written comments. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/printing/print_preview_pdf_generated_browsertest.cc ('K') | « chrome/browser/ui/webui/print_preview/print_preview_handler.h ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/print_preview/print_preview_ui.h

diff --git a/chrome/browser/ui/webui/print_preview/print_preview_ui.h b/chrome/browser/ui/webui/print_preview/print_preview_ui.h

index 7f32261dad683cb41ea074ec27d46de9b11e7d86..0fe046228cdedb170bed324639562ba71f405262 100644

--- a/chrome/browser/ui/webui/print_preview/print_preview_ui.h

+++ b/chrome/browser/ui/webui/print_preview/print_preview_ui.h

@@ -156,6 +156,7 @@ class PrintPreviewUI : public ConstrainedWebDialogUI {

private:

friend class PrintPreviewHandlerTest;

+ friend class PrintPreviewPdfGeneratedBrowserTest;

Lei Zhang 2014/07/11 04:15:07 Maybe just add a public SetSelectedFileForTesting

ivandavid 2014/07/16 20:06:34 Done.

FRIEND_TEST_ALL_PREFIXES(PrintPreviewHandlerTest, StickyMarginsCustom);

FRIEND_TEST_ALL_PREFIXES(PrintPreviewHandlerTest, StickyMarginsDefault);

FRIEND_TEST_ALL_PREFIXES(PrintPreviewHandlerTest,

@@ -166,6 +167,8 @@ class PrintPreviewUI : public ConstrainedWebDialogUI {

GetLastUsedMarginSettingsDefault);

FRIEND_TEST_ALL_PREFIXES(PrintPreviewDialogControllerUnitTest,

TitleAfterReload);

+ FRIEND_TEST_ALL_PREFIXES(PrintPreviewPdfGeneratedBrowserTest,

+ MANUAL_DummyTest);

// Returns the Singleton instance of the PrintPreviewDataService.

PrintPreviewDataService* print_preview_data_service();