Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4194)

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_ui.h

Issue 383623002: Add a browser test that can communicate with the layout test framework and print pdfs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Browsertest now works on Windows and Mac. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/print_preview/print_preview_ui.h
diff --git a/chrome/browser/ui/webui/print_preview/print_preview_ui.h b/chrome/browser/ui/webui/print_preview/print_preview_ui.h
index 7f32261dad683cb41ea074ec27d46de9b11e7d86..44c56522b4f1fb170e6aab95128a0487e8805805 100644
--- a/chrome/browser/ui/webui/print_preview/print_preview_ui.h
+++ b/chrome/browser/ui/webui/print_preview/print_preview_ui.h
@@ -7,6 +7,7 @@
#include <string>
+#include "base/files/file_path.h"
Lei Zhang 2014/07/17 00:30:37 you can forward declare instead.
ivandavid 2014/07/17 20:49:20 Done.
#include "base/gtest_prod_util.h"
#include "base/memory/ref_counted.h"
#include "base/time/time.h"
@@ -154,6 +155,11 @@ class PrintPreviewUI : public ConstrainedWebDialogUI {
static void SetDelegateForTesting(TestingDelegate* delegate);
+ // Allows for tests to set a file path to print a PDF to. This lso initiates
Lei Zhang 2014/07/17 00:30:37 lso?
ivandavid 2014/07/17 20:49:21 Oops, should be 'also.'
+ // the printing without having to click a button on the print preview dialog.
+ void SetSelectedFileForTesting(
+ const base::FilePath& path, int index, void* params);
Lei Zhang 2014/07/17 00:30:37 |index| and |param| are ultimately unused. Omit th
ivandavid 2014/07/17 20:49:20 Done.
+
private:
friend class PrintPreviewHandlerTest;
FRIEND_TEST_ALL_PREFIXES(PrintPreviewHandlerTest, StickyMarginsCustom);

Powered by Google App Engine
This is Rietveld 408576698