build/java_apk.gypi - Issue 383613002: Make android_apk template actually create an apk

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/java_apk.gypi

Issue 383613002: Make android_apk template actually create an apk (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-apk-dex

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/java_apk.gypi

diff --git a/build/java_apk.gypi b/build/java_apk.gypi

index 9465279437a7d445c571c8d01fb37cc00cfcd66f..3e1f981fa399d68c11748ecc72f5354a23a9d992 100644

--- a/build/java_apk.gypi

+++ b/build/java_apk.gypi

@@ -867,7 +867,9 @@

'action': [

'python', '<(DEPTH)/build/android/gyp/ant.py',

+ '--',

newt (away) 2014/07/30 21:23:14 why "--" ?

cjhopman 2014/07/31 22:15:05 Python's optparse will discard a "--" and stop pro

'-quiet',

+ '-DDEX_FILE_PATH=<(intermediate_dir)/classes.dex',

'-DANDROID_SDK_ROOT=<(android_sdk_root)',

'-DANDROID_SDK_TOOLS=<(android_sdk_tools)',

'-DRESOURCE_PACKAGED_APK_NAME=<(resource_packaged_apk_name)',

« build/config/android/rules.gni ('K') | « build/config/android/rules.gni ('k') | no next file » | no next file with comments »