Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: build/config/android/rules.gni

Issue 383613002: Make android_apk template actually create an apk (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-apk-dex
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/android/internal_rules.gni ('k') | build/java_apk.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/android/rules.gni
diff --git a/build/config/android/rules.gni b/build/config/android/rules.gni
index 924c261a6b9529716f50b53d3ce6c68d35b7cf43..61a83223242a57213a78dcb17f657cacae4617e7 100644
--- a/build/config/android/rules.gni
+++ b/build/config/android/rules.gni
@@ -506,9 +506,16 @@ template("android_apk") {
# Just mark these as used for now.
assert(!defined(invoker.native_libs)
|| invoker.native_libs == [] || true)
- assert(!defined(invoker.final_apk_path)
- || invoker.final_apk_path == "" || true)
+ _keystore_path = android_default_keystore_path
+ _keystore_name = android_default_keystore_name
+ _keystore_password = android_default_keystore_password
+
+ if (defined(invoker.keystore_path)) {
+ _keystore_path = invoker.keystore_path
+ _keystore_name = invoker.keystore_name
+ _keystore_password = invoker.keystore_password
+ }
# TODO(cjhopman): Remove this once we correctly generate the real
# NativeLibraries.java
@@ -558,6 +565,20 @@ template("android_apk") {
args = ["--inputs=@FileArg($dex_arg_key)"]
}
+ final_deps += [":${target_name}__create"]
+ create_apk("${target_name}__create") {
+ apk_path = invoker.final_apk_path
+ android_manifest = invoker.android_manifest
+ resources_zip = all_resources_zip_path
+ dex_path = final_dex_path
+
+ keystore_name = _keystore_name
+ keystore_path = _keystore_path
+ keystore_password = _keystore_password
+
+ # TODO: native libs
+ }
+
group(target_name) {
deps = final_deps
}
« no previous file with comments | « build/config/android/internal_rules.gni ('k') | build/java_apk.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698