Source/core/page/scrolling/ScrollingCoordinator.cpp - Issue 383603002: Update scrollbar layer opacity when scrollbar theme changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/scrolling/ScrollingCoordinator.cpp

Issue 383603002: Update scrollbar layer opacity when scrollbar theme changes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Update test expectations Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/scrolling/ScrollingCoordinator.cpp

diff --git a/Source/core/page/scrolling/ScrollingCoordinator.cpp b/Source/core/page/scrolling/ScrollingCoordinator.cpp

index 1e8df3c7b2955f0e3de34d5cf55ccf66a57f036f..29d32e62a55265d45a37ec489e66b16bfcfbab65 100644

--- a/Source/core/page/scrolling/ScrollingCoordinator.cpp

+++ b/Source/core/page/scrolling/ScrollingCoordinator.cpp

@@ -346,9 +346,7 @@ void ScrollingCoordinator::scrollableAreaScrollbarLayerDidChange(ScrollableArea*

// Root layer non-overlay scrollbars should be marked opaque to disable

// blending.

bool isOpaqueScrollbar = !scrollbar->isOverlayScrollbar();

- if (!scrollbarGraphicsLayer->contentsOpaque())

- scrollbarGraphicsLayer->setContentsOpaque(isMainFrame && isOpaqueScrollbar);

- scrollbarLayer->layer()->setOpaque(scrollbarGraphicsLayer->contentsOpaque());

+ scrollbarGraphicsLayer->setContentsOpaque(isMainFrame && isOpaqueScrollbar);

WebLayer* scrollLayer = toWebLayer(scrollableArea->layerForScrolling());

WebLayer* containerLayer = toWebLayer(scrollableArea->layerForContainer());

« no previous file with comments | « LayoutTests/TestExpectations ('k') | Source/platform/graphics/GraphicsLayer.cpp » ('j') | no next file with comments »