Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Issue 383583003: Make the Viewport class pure model. (Closed)

Created:
6 years, 5 months ago by hirono
Modified:
6 years, 5 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Make the Viewport class pure model. The CL removes the unused scaleControl proeprty in the view port class. BUG=245926 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282279

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M ui/file_manager/gallery/js/image_editor/viewport.js View 5 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hirono
PTAL the CL?
6 years, 5 months ago (2014-07-10 02:42:58 UTC) #1
fukino
On 2014/07/10 02:42:58, hirono wrote: > PTAL the CL? LGTM!
6 years, 5 months ago (2014-07-10 03:45:20 UTC) #2
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 5 months ago (2014-07-10 03:48:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/383583003/1
6 years, 5 months ago (2014-07-10 03:49:30 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 07:58:23 UTC) #5
Message was sent while issue was closed.
Change committed as 282279

Powered by Google App Engine
This is Rietveld 408576698