core/include/fxcrt/fx_string.h - Issue 383563002: Fix an out-of-boundary issue for wide string

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/include/fxcrt/fx_string.h

Issue 383563002: Fix an out-of-boundary issue for wide string (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Tabify files Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/include/fxcrt/fx_string.h

diff --git a/core/include/fxcrt/fx_string.h b/core/include/fxcrt/fx_string.h

index fe56e1867ecaf73110c162ca4810a129b74d4bb6..ed2850cf3d8603c0382afced0d00bc68d9413f41 100644

--- a/core/include/fxcrt/fx_string.h

+++ b/core/include/fxcrt/fx_string.h

@@ -634,9 +634,9 @@ public:

static CFX_WideString FromLocal(const char* str, FX_STRSIZE len = -1);

- static CFX_WideString FromUTF8(const char* str, FX_STRSIZE len = -1);

+ static CFX_WideString FromUTF8(const char* str, FX_STRSIZE len);

- static CFX_WideString FromUTF16LE(const unsigned short* str, FX_STRSIZE len = -1);

+ static CFX_WideString FromUTF16LE(const unsigned short* str, FX_STRSIZE len);

operator FX_LPCWSTR() const

{

« no previous file with comments | « no previous file | core/src/fxcrt/fx_basic_util.cpp » ('j') | core/src/fxcrt/fx_basic_wstring.cpp » ('J')