fpdfsdk/src/jsapi/fxjs_v8.cpp - Issue 383563002: Fix an out-of-boundary issue for wide string

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/jsapi/fxjs_v8.cpp

Issue 383563002: Fix an out-of-boundary issue for wide string (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/jsapi/fxjs_v8.cpp

diff --git a/fpdfsdk/src/jsapi/fxjs_v8.cpp b/fpdfsdk/src/jsapi/fxjs_v8.cpp

index f2336ab2fc5ed68a4737a762904cf845a8e09f15..5eb9873f5ce5d73073f5548cead75805487be27f 100644

--- a/fpdfsdk/src/jsapi/fxjs_v8.cpp

+++ b/fpdfsdk/src/jsapi/fxjs_v8.cpp

@@ -734,7 +734,7 @@ CFX_WideString JS_ToString(v8::Handle<v8::Value> pValue)

{

if(pValue.IsEmpty()) return L"";

v8::String::Utf8Value s(pValue->ToString());

- return CFX_WideString::FromUTF8(*s);

+ return CFX_WideString::FromUTF8(*s, s.length());

palmer 2014/07/10 19:10:55 Ahh, I see, FromUTF8 has the same behavior. There

}

v8::Handle<v8::Array> JS_ToArray(v8::Handle<v8::Value> pValue)

« fpdfsdk/src/javascript/app.cpp ('K') | « fpdfsdk/src/javascript/app.cpp ('k') | no next file » | no next file with comments »