Fix an out-of-boundary issue for wide string

fpdfsdk/src/javascript/Document.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/javascript/JavaScript.h"
 #include "../../include/javascript/IJavaScript.h"
 #include "../../include/javascript/JS_Define.h"
 #include "../../include/javascript/JS_Object.h"
@@ skipping 178 matching lines @@
         m_DelayAnnotData.RemoveAll();
 }
 
 //the total number of fileds in document.
 FX_BOOL Document::numFields(OBJ_PROP_PARAMS)
 {
         if (!vp.IsGetting()) return FALSE;
 
         ASSERT(m_pDocument != NULL);
 
-        CPDFSDK_InterForm *pInterForm = m_pDocument->GetInterForm();
+        CPDFSDK_InterForm *pInterForm = m_pDocument->GetInterForm();
         ASSERT(pInterForm != NULL);
 
         CPDF_InterForm *pPDFForm = pInterForm->GetInterForm();
         ASSERT(pPDFForm != NULL);
 
         vp << (int)pPDFForm->CountFields();
 
         return TRUE;
 }
 
@@ skipping 67 matching lines @@
                 else if (iPageNum >= iPageCount)
                 {
                          pEnv->JS_docgotoPage(iPageCount-1);
                 }
                 else if (iPageNum < 0)
                 {
                          pEnv->JS_docgotoPage(0);
                 }
         }
 
-        return TRUE;
+        return TRUE;
 }
 
 FX_BOOL Document::ParserParams(JSObject* pObj,CJS_AnnotObj& annotobj)
 {
         return TRUE;
 }
 
 FX_BOOL Document::addAnnot(OBJ_METHOD_PARAMS)
 {
-        return TRUE;
+        return TRUE;
 }
 
 FX_BOOL Document::addField(OBJ_METHOD_PARAMS)
 {
         //Doesn't support.
         return TRUE;
 }
 
 //exports form fields as a tab-delimited text file to a local hard disk.
 //comment: need reader support
@@ skipping 21 matching lines @@
 
         if (!m_pDocument->GetPermissions(FPDFPERM_EXTRACT_ACCESS)) return FALSE;
 
         FX_BOOL bAllFields = params.size() > 0 ? (FX_BOOL)params[0] : FALSE;
         FX_BOOL bNoPassWord = params.size() > 1 ? (FX_BOOL)params[1] : TRUE;
         FX_BOOL bWhole = params.size() > 2 ? (params[2].GetType() == VT_null) : TRUE;
         CJS_Array arrayFileds(isolate);
         if (!bWhole)
                 arrayFileds.Attach(params[2]);
         //FX_BOOL bFlags = params.size() > 3 ? (FX_BOOL)params[3] : FALSE;
-    CFX_WideString swFilePath = params.size() > 4 ? (FX_LPCWSTR)params[4].operator CFX_WideString() : (FX_LPCWSTR)L"";
+        CFX_WideString swFilePath = params.size() > 4 ? (FX_LPCWSTR)params[4].operator CFX_WideString() : (FX_LPCWSTR)L"";
 
         if (swFilePath.IsEmpty())
         {
                 CPDFDoc_Environment* pEnv = m_pDocument->GetEnv();
                 swFilePath = pEnv->JS_fieldBrowse();
                 if(swFilePath.IsEmpty())
                         return TRUE;
         }
         else
         {
                 swFilePath = app::PDFPathToSysPath(swFilePath);
         }
-    
+        
         m_pDocument->SetFocusAnnot(NULL);
    
-    CPDFSDK_InterForm* pInterForm= (CPDFSDK_InterForm*)m_pDocument->GetInterForm();
+        CPDFSDK_InterForm* pInterForm= (CPDFSDK_InterForm*)m_pDocument->GetInterForm();
         ASSERT(pInterForm != NULL);
 
         CPDF_InterForm* pPDFForm = pInterForm->GetInterForm();
         ASSERT(pPDFForm != NULL);
 
         CFX_PtrArray aFields;
 
         if (bWhole)
         {
                 for (int j=0,jsz=pPDFForm->CountFields(); j<jsz; j++)
@@ skipping 13 matching lines @@
                         {
                                 aFields.Add(pPDFForm->GetField(j, swName));
                         }
                 }
         }
 
         CFX_PtrArray fields;
 
         for (int i=0,sz=aFields.GetSize(); i<sz; i++)
         {
-            CPDF_FormField* pField = (CPDF_FormField*)aFields[i];
+                CPDF_FormField* pField = (CPDF_FormField*)aFields[i];
                 
                 if (!bAllFields)
                         if (pField->GetValue() == L"")
                                 continue;
 
                 if (bNoPassWord)
                         if (pField->GetFieldFlags() & 0x2000)
                                 continue;
 
-        fields.Add((void*)pField);
+                fields.Add((void*)pField);
         }    
 
-    return pInterForm->ExportFieldsToFDFFile(swFilePath, fields, TRUE);
+        return pInterForm->ExportFieldsToFDFFile(swFilePath, fields, TRUE);
 }
 
 //exports form fields an XFDF file to the local hard drive
 //comment: need reder supports
 //note:the last parameter can't be test
 //int CPDFSDK_Document::ExportAsXFDF(FX_BOOL bAllFields,FX_BOOL  bNoPassWord,StringArray aFields,String cPath,FX_BOOL bAnnoatations);
 
 FX_BOOL Document::exportAsXFDF(OBJ_METHOD_PARAMS)
 {
         if (IsSafeMode(cc)) return TRUE;
@@ skipping 10 matching lines @@
 
 FX_BOOL Document::getField(OBJ_METHOD_PARAMS)
 {
         v8::Isolate* isolate = GetIsolate(cc);
         ASSERT(m_pDocument != NULL);
 
         if (params.size() < 1) return FALSE;
 
         CFX_WideString wideName = params[0].operator CFX_WideString();
 
-    CPDFSDK_InterForm* pInterForm = m_pDocument->GetInterForm();
+        CPDFSDK_InterForm* pInterForm = m_pDocument->GetInterForm();
         ASSERT(pInterForm != NULL);
 
         CPDF_InterForm* pPDFForm = pInterForm->GetInterForm();
         ASSERT(pPDFForm != NULL);
 
         if (pPDFForm->CountFields(wideName) <= 0) 
         {
                 vRet.SetNull();
                 return TRUE;
         }
@@ skipping 54 matching lines @@
 
         if (!(m_pDocument->GetPermissions(FPDFPERM_MODIFY) || 
                 m_pDocument->GetPermissions(FPDFPERM_ANNOT_FORM) ||
                 m_pDocument->GetPermissions(FPDFPERM_FILL_FORM))) return FALSE;
 
 
         CFX_WideString swPath;
         
         if (params.size() > 0)
                 swPath = params[0];
-    
+        
         if (swPath.IsEmpty())
         {
                 CPDFDoc_Environment* pEnv = m_pDocument->GetEnv();
                 swPath = pEnv->JS_fieldBrowse();
                 if(swPath.IsEmpty())
                         return TRUE;
         }
         else
         {
                 swPath = app::PDFPathToSysPath(swPath);
         }
 
         m_pDocument->SetFocusAnnot(NULL);
 
         CPDFSDK_InterForm* pInterForm = (CPDFSDK_InterForm*)m_pDocument->GetInterForm();
         ASSERT(pInterForm != NULL);
 
         if (!pInterForm->ImportFormFromFDFFile(swPath, TRUE))
                 return FALSE;
 
-        m_pDocument->SetChangeMark();
+        m_pDocument->SetChangeMark();
 //      CPDFDoc_Environment* pEnv = m_pDocument->GetEnv();
 //      ASSERT(pEnv != NULL);
 //      IUndo* pUndo = IUndo::GetUndo(pEnv);
 //      ASSERT(pUndo != NULL);
 //      pUndo->Reset(m_pDocument);
 
         return TRUE;
 }
 
 //imports and specified XFDF file containing XML form data
@@ skipping 58 matching lines @@
                 return FALSE;
 
         CJS_Context* pContext = (CJS_Context*)cc;
         ASSERT(pContext != NULL);
         CPDFDoc_Environment* pEnv = pContext->GetReaderApp();
         ASSERT(pEnv != NULL);
         CJS_Runtime* pRuntime = pContext->GetJSRuntime();
         ASSERT(pRuntime != NULL);
 
         pRuntime->BeginBlock();
-    pEnv->JS_docmailForm(textBuf.GetBuffer(), textBuf.GetLength(), bUI, (FX_LPCWSTR)cTo, (FX_LPCWSTR)cSubject, (FX_LPCWSTR)cCc, (FX_LPCWSTR)cBcc, (FX_LPCWSTR)cMsg);
+        pEnv->JS_docmailForm(textBuf.GetBuffer(), textBuf.GetLength(), bUI, (FX_LPCWSTR)cTo, (FX_LPCWSTR)cSubject, (FX_LPCWSTR)cCc, (FX_LPCWSTR)cBcc, (FX_LPCWSTR)cMsg);
         pRuntime->EndBlock();
-        return TRUE;
+        return TRUE;
 }
 
 FX_BOOL Document::print(OBJ_METHOD_PARAMS)
 {
         CJS_Context* pContext = (CJS_Context*)cc;
         ASSERT(pContext != NULL);
         CJS_Runtime* pRuntime = pContext->GetJSRuntime();
         ASSERT(pRuntime != NULL);
 
         FX_BOOL bUI = TRUE;
@@ skipping 32 matching lines @@
                         }       
                 }
         }
         else
         {
                 if(nlength >= 1)
                          bUI = params[0];
                 if(nlength >= 2)
                          nStart = (int)params[1];
                 if(nlength >= 3)
-                    nEnd = (int)params[2];
+                        nEnd = (int)params[2];
                 if(nlength >= 4)
                         bSilent = params[3];
                 if(nlength >= 5)
-                    bShrinkToFit = params[4];
+                        bShrinkToFit = params[4];
                 if(nlength >= 6)
                         bPrintAsImage = params[5];
                 if(nlength >= 7)
                         bReverse = params[6];
                 if(nlength >= 8)
                         bAnnotations = params[7];
         }
 
-        ASSERT(m_pDocument != NULL);
+        ASSERT(m_pDocument != NULL);
  
-        if (CPDFDoc_Environment* pEnv = m_pDocument->GetEnv())
-        {
+        if (CPDFDoc_Environment* pEnv = m_pDocument->GetEnv())
+        {
                 pEnv->JS_docprint(bUI, nStart, nEnd, bSilent, bShrinkToFit, bPrintAsImage, bReverse, bAnnotations);
-                return TRUE;
-        }
+                return TRUE;
+        }
         return FALSE;
 }
 
 //removes the specified field from the document.
 //comment:
 //note: if the filed name is not retional, adobe is dumb for it.
 
 FX_BOOL Document::removeField(OBJ_METHOD_PARAMS)
 {
         ASSERT(m_pDocument != NULL);
@@ skipping 86 matching lines @@
                         CFX_WideString swVal = valElement.operator CFX_WideString();    
                         
                         for (int j=0,jsz=pPDFForm->CountFields(swVal); j<jsz; j++)
                         {
                                 aFields.Add((void*)pPDFForm->GetField(j,swVal));
                         }               
                 }
 
                 if (aFields.GetSize() > 0)
                 {
-                        pPDFForm->ResetForm(aFields, TRUE, TRUE);
-                        m_pDocument->SetChangeMark();
+                        pPDFForm->ResetForm(aFields, TRUE, TRUE);
+                        m_pDocument->SetChangeMark();
 
                 }
         }
         else
         {
-                pPDFForm->ResetForm(TRUE);
-                m_pDocument->SetChangeMark();
+                pPDFForm->ResetForm(TRUE);
+                m_pDocument->SetChangeMark();
 
         }
 
         return TRUE;
 }
 
 
 FX_BOOL Document::saveAs(OBJ_METHOD_PARAMS)
 {
 
@@ skipping 255 matching lines @@
                 JS_PutObjectString(isolate,pObj, L"CreationDate", cwCreationDate);
                 JS_PutObjectString(isolate,pObj, L"ModDate", cwModDate);
                 JS_PutObjectString(isolate,pObj, L"Trapped", cwTrapped);
 
 // It's to be compatible to non-standard info dictionary.       
                 FX_POSITION pos = pDictionary->GetStartPos();
                 while(pos)
                 {
                         CFX_ByteString bsKey;
                         CPDF_Object* pValueObj = pDictionary->GetNextElement(pos, bsKey);
-                        CFX_WideString wsKey  = CFX_WideString::FromUTF8(bsKey);
+                        CFX_WideString wsKey  = CFX_WideString::FromUTF8(bsKey, bsKey.GetLength());
                         if((pValueObj->GetType()==PDFOBJ_STRING) || (pValueObj->GetType()==PDFOBJ_NAME) )
                                         JS_PutObjectString(isolate,pObj, wsKey, pValueObj->GetUnicodeText());
                         if(pValueObj->GetType()==PDFOBJ_NUMBER)
                                 JS_PutObjectNumber(isolate,pObj, wsKey, (float)pValueObj->GetNumber());
                         if(pValueObj->GetType()==PDFOBJ_BOOLEAN)
                                 JS_PutObjectBoolean(isolate,pObj, wsKey, (bool)pValueObj->GetInteger());
                 }
 
                 vp << pObj;
                 return TRUE;
@@ skipping 265 matching lines @@
                         return TRUE;
                 }
         }
 
         vp << 0;
         return TRUE;
 }
 
 FX_BOOL Document::mouseX(OBJ_PROP_PARAMS)
 {
-        return TRUE;    
+        return TRUE;    
 }
 
 FX_BOOL Document::mouseY(OBJ_PROP_PARAMS)
 {
-        return TRUE;
+        return TRUE;
 }
 
 FX_BOOL Document::baseURL(OBJ_PROP_PARAMS)
 {
         if (vp.IsGetting())
         {
                 vp << m_cwBaseURL;
                 return TRUE;
         }
         else
@@ skipping 111 matching lines @@
         return TRUE;
 }
 
 FX_BOOL Document::layout(OBJ_PROP_PARAMS)
 {       
         return TRUE;
 }
 
 FX_BOOL Document::addLink(OBJ_METHOD_PARAMS)
 {
-        return TRUE;
+        return TRUE;
 }
 
 FX_BOOL Document::closeDoc(OBJ_METHOD_PARAMS)
 {
         ASSERT(m_pDocument != NULL);
 
 
         
         
 
         return TRUE;
 }
 
 FX_BOOL Document::getPageBox(OBJ_METHOD_PARAMS)
 {
-        return TRUE;
+        return TRUE;
 }
 
 
 FX_BOOL Document::getAnnot(OBJ_METHOD_PARAMS)
 {
-        return TRUE;
+        return TRUE;
 }
 
 FX_BOOL Document::getAnnots(OBJ_METHOD_PARAMS)
 {
         vRet.SetNull();
         return TRUE;
 }
 
 FX_BOOL Document::getAnnot3D(OBJ_METHOD_PARAMS)
 {
@@ skipping 996 matching lines @@
 
 void Document::DoAnnotDelay()
 {
         CFX_DWordArray DelArray;
         
         for (int j=DelArray.GetSize()-1; j>=0; j--)
         {
                 m_DelayData.RemoveAt(DelArray[j]);
         }
 }