Fix an out-of-boundary issue for wide string

core/src/fxge/win32/fx_win32_device.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../include/fxge/fx_ge.h"
 #if _FX_OS_ == _FX_WIN32_DESKTOP_ || _FX_OS_ == _FX_WIN64_
 #include "../../../include/fxge/fx_ge_win32.h"
 #include <crtdbg.h>
@@ skipping 310 matching lines @@
     HFONT hOldFont = (HFONT)::SelectObject(m_hDC, hFont);
     int ret = ::GetTextFaceA(m_hDC, 100, facebuf);
     ::SelectObject(m_hDC, hOldFont);
     if (face.EqualNoCase(facebuf)) {
         return hFont;
     }
     int iCount = sizeof(VariantNames) / sizeof(VariantNames[0]);
     for (int i = 0; i < iCount; ++i) {
         if (face == VariantNames[i].m_pFaceName) {
             CFX_WideString wsFace = CFX_WideString::FromLocal(facebuf);
-            CFX_WideString wsName = CFX_WideString::FromUTF16LE((const unsigned short*)VariantNames[i].m_pVariantName);
+            const unsigned short* pName = (const unsigned short*)VariantNames[i].m_pVariantName;
+            FX_STRSIZE len = 0;
+            while (pName[len]) len++;

[palmer, 2014/07/12 00:54:39]

Use wcslen?

[Bo Xu, 2014/07/12 05:18:04]

Done.

+            CFX_WideString wsName = CFX_WideString::FromUTF16LE(pName, len);
+
             if (wsFace == wsName) {
                 return hFont;
             }
         }
     }
     ::DeleteObject(hFont);
     if (charset == DEFAULT_CHARSET) {
         return NULL;
     }
     switch (charset) {
@@ skipping 854 matching lines @@
     if (m_hDC) {
         SelectObject(m_hDC, m_hOldBitmap);
         DeleteDC(m_hDC);
     }
     if (m_hBitmap) {
         DeleteObject(m_hBitmap);
     }
     delete GetBitmap();
 }
 #endif