Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1403)

Issue 383543004: Pepper: Initialize PP_ImageDataDesc when creating ImageData. (Closed)

Created:
6 years, 5 months ago by bbudge
Modified:
6 years, 5 months ago
CC:
chromium-reviews, Tom Sepez
Project:
chromium
Visibility:
Public.

Description

Pepper: Initialize PP_ImageDataDesc when creating ImageData. Clears memory so we don't send unitialized memory to the renderer. BUG=391023 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282222

Patch Set 1 #

Patch Set 2 : Spelling. #

Total comments: 2

Patch Set 3 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ppapi/proxy/ppb_image_data_proxy.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
bbudge
6 years, 5 months ago (2014-07-09 22:51:48 UTC) #1
dmichael (off chromium)
Why are you working?? lgtm https://codereview.chromium.org/383543004/diff/20001/ppapi/proxy/ppb_image_data_proxy.cc File ppapi/proxy/ppb_image_data_proxy.cc (right): https://codereview.chromium.org/383543004/diff/20001/ppapi/proxy/ppb_image_data_proxy.cc#newcode500 ppapi/proxy/ppb_image_data_proxy.cc:500: memset(&desc, 0, sizeof(desc)); I ...
6 years, 5 months ago (2014-07-09 23:11:16 UTC) #2
bbudge
https://codereview.chromium.org/383543004/diff/20001/ppapi/proxy/ppb_image_data_proxy.cc File ppapi/proxy/ppb_image_data_proxy.cc (right): https://codereview.chromium.org/383543004/diff/20001/ppapi/proxy/ppb_image_data_proxy.cc#newcode500 ppapi/proxy/ppb_image_data_proxy.cc:500: memset(&desc, 0, sizeof(desc)); On 2014/07/09 23:11:16, dmichael wrote: > ...
6 years, 5 months ago (2014-07-09 23:34:53 UTC) #3
bbudge
The CQ bit was checked by bbudge@chromium.org
6 years, 5 months ago (2014-07-09 23:35:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/383543004/40001
6 years, 5 months ago (2014-07-09 23:37:07 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 02:54:16 UTC) #6
Message was sent while issue was closed.
Change committed as 282222

Powered by Google App Engine
This is Rietveld 408576698