Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 383523004: [NaCl SDK] docs: Remove references to obsolete debugging env vars. (Closed)

Created:
6 years, 5 months ago by jvoung (off chromium)
Modified:
6 years, 5 months ago
Reviewers:
bbudge, sehr, binji
CC:
chromium-reviews, binji+watch_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg
Visibility:
Public.

Description

[NaCl SDK] docs: Remove references to obsolete debugging env vars. Make also complained about some broken links and stopped w/ warnings as errors. I assume a bunch these went away w/ the really old proxy switch =) BUG=266395 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282653

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : undo middleware change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -13 lines) Patch
M native_client_sdk/doc_generated/community/index.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/doc_generated/devguide/devcycle/debugging.html View 1 1 chunk +0 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/devcycle/dynamic-loading.html View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M native_client_sdk/doc_generated/faq.html View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/doc/devguide/devcycle/debugging.rst View 1 1 chunk +0 lines, -3 lines 0 comments Download
M native_client_sdk/src/doc/devguide/devcycle/dynamic-loading.rst View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M native_client_sdk/src/doc/faq.rst View 1 1 chunk +1 line, -1 line 0 comments Download
M ppapi/native_client/tools/browser_tester/browsertester/browserlauncher.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jvoung (off chromium)
6 years, 5 months ago (2014-07-09 21:28:29 UTC) #1
bbudge
There's another reference in NaCl: https://code.google.com/p/chromium/codesearch#chromium/src/native_client/src/trusted/service_runtime/env_cleanser.c&q=NACL_PPAPI_PROXY_DEBUG&sq=package:chromium&type=cs&l=53
6 years, 5 months ago (2014-07-09 21:36:49 UTC) #2
bbudge
LGTM
6 years, 5 months ago (2014-07-09 21:37:14 UTC) #3
sehr
lgtm
6 years, 5 months ago (2014-07-09 21:37:58 UTC) #4
jvoung (off chromium)
On 2014/07/09 21:36:49, bbudge (OOO July 1-8) wrote: > There's another reference in NaCl: > ...
6 years, 5 months ago (2014-07-09 22:31:55 UTC) #5
jvoung (off chromium)
Rebased (my client was super old) Ben, can I get an OWNERS review? sehr is ...
6 years, 5 months ago (2014-07-11 17:29:15 UTC) #6
binji
lgtm
6 years, 5 months ago (2014-07-11 17:34:34 UTC) #7
jvoung (off chromium)
The CQ bit was checked by jvoung@chromium.org
6 years, 5 months ago (2014-07-11 18:04:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@chromium.org/383523004/40001
6 years, 5 months ago (2014-07-11 18:06:20 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 18:08:53 UTC) #10
Message was sent while issue was closed.
Change committed as 282653

Powered by Google App Engine
This is Rietveld 408576698