Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: runtime/vm/assembler_arm64.cc

Issue 383443002: Removes branches from LoadTaggedClassIdMayBeSmi. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/assembler_ia32.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_arm64.cc
===================================================================
--- runtime/vm/assembler_arm64.cc (revision 38085)
+++ runtime/vm/assembler_arm64.cc (working copy)
@@ -1076,15 +1076,27 @@
void Assembler::LoadTaggedClassIdMayBeSmi(Register result, Register object) {
- Label load, done;
- tsti(object, kSmiTagMask);
- b(&load, NE);
- LoadImmediate(result, Smi::RawValue(kSmiCid), PP);
- b(&done);
- Bind(&load);
- LoadClassId(result, object, PP);
+ ASSERT(result != TMP);
+ ASSERT(object != TMP);
+
+ // Make a copy of object since result and object can be the same register.
+ mov(TMP, object);
+ // Load up a null object. We only need it so we can use LoadClassId on it in
+ // the case that object is a Smi..
+ LoadObject(result, Object::null_object(), PP);
+ // Check if the object is a Smi.
+ tsti(TMP, kSmiTagMask);
+ // If the object *is* a Smi, load the null object into tmp. o/w leave alone.
+ csel(TMP, result, TMP, EQ);
+ // Loads either the cid of the object if it isn't a Smi, or the cid of null
+ // if it is a Smi, which will be ignored.
+ LoadClassId(result, TMP, PP);
+
+ LoadImmediate(TMP, kSmiCid, PP);
+ // If object is a Smi, move the Smi cid into result. o/w leave alone.
+ csel(result, TMP, result, EQ);
+ // Finally, tag the result.
SmiTag(result);
- Bind(&done);
}
« no previous file with comments | « no previous file | runtime/vm/assembler_ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698