Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 383363002: DevTools: Fix async stacks instrumentation for XHRs. (Closed)

Created:
6 years, 5 months ago by aandrey
Modified:
6 years, 5 months ago
Reviewers:
pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, arv+blink, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Fix async stacks instrumentation for XHRs. This fixes 2 bugs: - XHR async call stacks could be deleted too early having the second onloadend callback w/o async stacks. - XHR async call stacks were not deleted at all if there was no onloadend event listener attached (aka memory leak). BUG=272416 R=yurys, pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178154

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -35 lines) Patch
M LayoutTests/inspector/sources/debugger/async-callstack-events.html View 2 chunks +11 lines, -4 lines 1 comment Download
M LayoutTests/inspector/sources/debugger/async-callstack-events-expected.txt View 2 chunks +10 lines, -4 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/async-callstack-xhrs.html View 3 chunks +10 lines, -4 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/async-callstack-xhrs-expected.txt View 3 chunks +29 lines, -12 lines 1 comment Download
M Source/core/inspector/AsyncCallStackTracker.h View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/inspector/AsyncCallStackTracker.cpp View 2 chunks +13 lines, -10 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
aandrey
https://codereview.chromium.org/383363002/diff/20001/LayoutTests/inspector/sources/debugger/async-callstack-events.html File LayoutTests/inspector/sources/debugger/async-callstack-events.html (right): https://codereview.chromium.org/383363002/diff/20001/LayoutTests/inspector/sources/debugger/async-callstack-events.html#newcode45 LayoutTests/inspector/sources/debugger/async-callstack-events.html:45: window.addEventListener("hashchange", onHashChange2, true); Note: this test would also pass ...
6 years, 5 months ago (2014-07-12 16:21:29 UTC) #1
yurys
lgtm
6 years, 5 months ago (2014-07-14 16:15:41 UTC) #2
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 5 months ago (2014-07-15 07:47:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/383363002/20001
6 years, 5 months ago (2014-07-15 07:47:26 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-15 08:49:51 UTC) #5
Message was sent while issue was closed.
Change committed as 178154

Powered by Google App Engine
This is Rietveld 408576698