Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2638)

Unified Diff: content/renderer/render_thread_impl.cc

Issue 383303004: Added more detailed result codes for CreateViewCommandBuffer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Deleted commented-out code from test. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_thread_impl.h ('k') | content/test/data/gpu/webgl_with_select_element.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_thread_impl.cc
diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc
index 6c4e7af10689e90feba5c56b03efec481a2609af..2666e22569efc3bcd3e2734e6b0c86c57610e0ac 100644
--- a/content/renderer/render_thread_impl.cc
+++ b/content/renderer/render_thread_impl.cc
@@ -1215,7 +1215,7 @@ scoped_ptr<base::SharedMemory> RenderThreadImpl::AllocateSharedMemory(
HostAllocateSharedMemoryBuffer(size));
}
-bool RenderThreadImpl::CreateViewCommandBuffer(
+CreateCommandBufferResult RenderThreadImpl::CreateViewCommandBuffer(
int32 surface_id,
const GPUCreateCommandBufferConfig& init_params,
int32 route_id) {
@@ -1224,17 +1224,17 @@ bool RenderThreadImpl::CreateViewCommandBuffer(
"surface_id",
surface_id);
- bool succeeded = false;
+ CreateCommandBufferResult result;
IPC::Message* message = new GpuHostMsg_CreateViewCommandBuffer(
surface_id,
init_params,
route_id,
- &succeeded);
+ &result);
// Allow calling this from the compositor thread.
thread_safe_sender()->Send(message);
- return succeeded;
+ return result;
}
void RenderThreadImpl::CreateImage(
« no previous file with comments | « content/renderer/render_thread_impl.h ('k') | content/test/data/gpu/webgl_with_select_element.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698