content/browser/gpu/browser_gpu_channel_host_factory.h - Issue 383303004: Added more detailed result codes for CreateViewCommandBuffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/gpu/browser_gpu_channel_host_factory.h

Issue 383303004: Added more detailed result codes for CreateViewCommandBuffer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Deleted commented-out code from test. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/gpu/browser_gpu_channel_host_factory.h

diff --git a/content/browser/gpu/browser_gpu_channel_host_factory.h b/content/browser/gpu/browser_gpu_channel_host_factory.h

index a442d160e65c135a4439e6655450ec141852a31e..dc85f67ff45cc7a26c217535c9deb2715ed5019f 100644

--- a/content/browser/gpu/browser_gpu_channel_host_factory.h

+++ b/content/browser/gpu/browser_gpu_channel_host_factory.h

@@ -29,7 +29,7 @@ class CONTENT_EXPORT BrowserGpuChannelHostFactory

virtual scoped_refptr<base::MessageLoopProxy> GetIOLoopProxy() OVERRIDE;

virtual scoped_ptr<base::SharedMemory> AllocateSharedMemory(

size_t size) OVERRIDE;

- virtual bool CreateViewCommandBuffer(

+ virtual CreateCommandBufferResult CreateViewCommandBuffer(

int32 surface_id,

const GPUCreateCommandBufferConfig& init_params,

int32 route_id) OVERRIDE;

@@ -85,7 +85,8 @@ class CONTENT_EXPORT BrowserGpuChannelHostFactory

CreateRequest* request,

int32 surface_id,

const GPUCreateCommandBufferConfig& init_params);

- static void CommandBufferCreatedOnIO(CreateRequest* request, bool succeeded);

+ static void CommandBufferCreatedOnIO(CreateRequest* request,

+ CreateCommandBufferResult result);

void CreateImageOnIO(

gfx::PluginWindowHandle window,

int32 image_id,

« no previous file with comments | « no previous file | content/browser/gpu/browser_gpu_channel_host_factory.cc » ('j') | no next file with comments »