Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3833004: Patch 2.4 branch with revisions 5643 and 5636. This fixes a problem with com... (Closed)

Created:
10 years, 2 months ago by William Hesse
Modified:
9 years, 7 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Patch 2.4 branch with revisions 5643 and 5636. This fixes a problem with comparison of smis in the full compiler, and a problem compiling on ARM with GCC 4.4. Committed: http://code.google.com/p/v8/source/detail?r=5659

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -34 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M src/arm/codegen-arm.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/codegen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/codegen.cc View 1 chunk +8 lines, -13 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/codegen-ia32.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/codegen-x64.h View 1 chunk +0 lines, -3 lines 0 comments Download
A test/mjsunit/int32-ops.js View 1 chunk +227 lines, -0 lines 0 comments Download
M test/mjsunit/smi-ops.js View 3 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
William Hesse
10 years, 2 months ago (2010-10-18 15:26:25 UTC) #1
fschneider
10 years, 2 months ago (2010-10-18 16:05:47 UTC) #2 
LGTM.

Powered by Google App Engine
This is Rietveld 408576698