Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 383283002: [Password Manager] Fix PasswordManager.SyncingAccountState labeling (Closed)

Created:
6 years, 5 months ago by Garrett Casto
Modified:
6 years, 5 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[Password Manager] Fix PasswordManager.SyncingAccountState labeling BUG=386403 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282749

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Garrett Casto
Apparently I can't do boolean arithmetic :(.
6 years, 5 months ago (2014-07-11 20:53:01 UTC) #1
Ilya Sherman
LGTM
6 years, 5 months ago (2014-07-11 21:00:38 UTC) #2
Garrett Casto
The CQ bit was checked by gcasto@chromium.org
6 years, 5 months ago (2014-07-11 21:03:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gcasto@chromium.org/383283002/1
6 years, 5 months ago (2014-07-11 21:04:17 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-12 00:09:18 UTC) #5
Message was sent while issue was closed. 
Change committed as 282749

Powered by Google App Engine
This is Rietveld 408576698