DescriptionFix a use after free crasher in the BrowserAccessibilityManagerWinTest.TestAccessibleHWND test.
The crash occurs because a scoped_ptr instance which holds the TestLegacyRenderWidgetHostHWND class
is left with a dangling pointer to the LegacyRenderWidgetHostHWND instance which is destroyed via
DestroyWindow.
Fix is to first reset the scoped_ptr which in turn destroys the legacy window and the instance.
The DestroyWindow call is removed as it is not needed anymore.
I also added a call to the CreateATLModuleIfNeeded helper function in BrowserAccessibility::Create as I was
hitting a crash due to a NULL AtlModule. We do this already in the ctor of the BrowserAccessibilityManagerWin
class. However that is too late as we have base classes which create COM objects.
This crash only happens in the component builds.
BUG=393228
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282759
Patch Set 1 #
Messages
Total messages: 5 (0 generated)
|