Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 383233005: Remove webkit_unit_tests_resources target. (Closed)

Created:
6 years, 5 months ago by tfarina
Modified:
6 years, 5 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, eseidel, jam, jamesr, jochen (gone - plz use gerrit)
Project:
blink
Visibility:
Public.

Description

Remove webkit_unit_tests_resources target. As tested, webkit_unit_tests does not need it to run. To test this, it was run the following command lines: - Apply this patch. $ rm -rf out/Debug $ ./build/gyp_chromium $ ninja -C out/Debug webkit_unit_tests $ out/Debug/webkit_unit_tests BUG=338338 TEST=see above R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178016

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -39 lines) Patch
M Source/web/web_tests.gyp View 2 chunks +1 line, -39 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
6 years, 5 months ago (2014-07-12 01:54:32 UTC) #1
abarth-chromium
lgtm
6 years, 5 months ago (2014-07-14 00:37:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/383233005/1
6 years, 5 months ago (2014-07-14 00:37:53 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 01:01:27 UTC) #4
Message was sent while issue was closed.
Change committed as 178016

Powered by Google App Engine
This is Rietveld 408576698