Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 38323003: Add authorization to crash reports (Closed)

Created:
7 years, 2 months ago by vadimt
Modified:
7 years, 1 month ago
Reviewers:
robliao, rgustafson, skare_
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Add authorization to crash reports. BUG=164227 TEST=No Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231718

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixing unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -5 lines) Patch
M chrome/browser/resources/google_now/utility.js View 1 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/resources/google_now/utility_unittest.gtestjs View 1 4 chunks +44 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
vadimt
7 years, 2 months ago (2013-10-23 22:14:56 UTC) #1
robliao
https://codereview.chromium.org/38323003/diff/1/chrome/browser/resources/google_now/utility.js File chrome/browser/resources/google_now/utility.js (right): https://codereview.chromium.org/38323003/diff/1/chrome/browser/resources/google_now/utility.js#newcode147 chrome/browser/resources/google_now/utility.js:147: request.setRequestHeader('Authorization', 'Bearer ' + token); setAuthorization reusuable here?
7 years, 2 months ago (2013-10-23 22:24:15 UTC) #2
skare_
lgtm
7 years, 2 months ago (2013-10-23 22:26:25 UTC) #3
rgustafson
lgtm
7 years, 2 months ago (2013-10-23 22:29:47 UTC) #4
vadimt
https://codereview.chromium.org/38323003/diff/1/chrome/browser/resources/google_now/utility.js File chrome/browser/resources/google_now/utility.js (right): https://codereview.chromium.org/38323003/diff/1/chrome/browser/resources/google_now/utility.js#newcode147 chrome/browser/resources/google_now/utility.js:147: request.setRequestHeader('Authorization', 'Bearer ' + token); On 2013/10/23 22:24:15, Robert ...
7 years, 2 months ago (2013-10-23 22:32:22 UTC) #5
robliao
lgtm
7 years, 2 months ago (2013-10-23 22:52:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vadimt@chromium.org/38323003/1
7 years, 1 month ago (2013-10-28 23:25:44 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=182026
7 years, 1 month ago (2013-10-29 01:07:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vadimt@chromium.org/38323003/1
7 years, 1 month ago (2013-10-29 01:09:32 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests, chrome_frame_net_tests, chrome_frame_tests, chrome_frame_unittests, content_browsertests, mini_installer_test, ...
7 years, 1 month ago (2013-10-29 01:57:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vadimt@chromium.org/38323003/420001
7 years, 1 month ago (2013-10-29 17:38:16 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=215080
7 years, 1 month ago (2013-10-30 00:19:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vadimt@chromium.org/38323003/420001
7 years, 1 month ago (2013-10-30 00:49:55 UTC) #13
commit-bot: I haz the power
7 years, 1 month ago (2013-10-30 03:05:56 UTC) #14
Message was sent while issue was closed. 
Change committed as 231718

Powered by Google App Engine
This is Rietveld 408576698