Issue 383213005: Pepper: Clarify end-of-bitcode-stream behavior.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 383213005: Pepper: Clarify end-of-bitcode-stream behavior. (Closed)

Created:
6 years, 5 months ago by teravest

Modified:
6 years, 5 months ago

Reviewers:
dmichael (off chromium)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Pepper: Clarify end-of-bitcode-stream behavior. The PutBytes() method in PnaclTranslateThread is used for two purposes: giving data to the translator processes and signaling the end of the stream. The way it's currently done is a bit confusing; this breaks the method into two for clarity. This is to make code review easier to read for an upcoming change which removes FileDownloader from the trusted plugin. BUG=370556 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282734

Patch Set 1 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -14 lines)			Patch
M	ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc	View	1 chunk	+8 lines, -3 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc	View	2 chunks	+8 lines, -11 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/383213005/20001

6 years, 5 months ago (2014-07-11 21:21:38 UTC) #4

Message was sent while issue was closed.

Change committed as 282734

Expand Messages | Collapse Messages