Start plumbing drm atomic swap.

Start plumbing drm atomic swap.

This creates an atomic plane to be updated during page flip.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282803

[alexst (slow to review), 2014-07-11 15:02:51]

Take a look, it's hidden behind a variable and we'll probably need a new atomic
display controller, but it's a first step.

[dnicoara, 2014-07-11 15:24:05]

https://codereview.chromium.org/383193002/diff/20001/ui/ozone/platform/dri/dr...
File ui/ozone/platform/dri/dri.gypi (right):

https://codereview.chromium.org/383193002/diff/20001/ui/ozone/platform/dri/dr...
ui/ozone/platform/dri/dri.gypi:16: 'use_drm_atomic_flip%': 0,
One thing that I forgot to mention yesterday was testing without having this
present in your GYP_DEFINES.

https://codereview.chromium.org/383193002/diff/20001/ui/ozone/platform/dri/ha...
File ui/ozone/platform/dri/hardware_display_plane.cc (right):

https://codereview.chromium.org/383193002/diff/20001/ui/ozone/platform/dri/ha...
ui/ozone/platform/dri/hardware_display_plane.cc:98: drmModeObjectPropertiesPtr
plane_props = drmModeObjectGetProperties(
Could you please add the type to scoped_drm_types.h and use that instead. This
is defined in the current API, so shouldn't require any fancy #ifdefs.

https://codereview.chromium.org/383193002/diff/20001/ui/ozone/platform/dri/ha...
File ui/ozone/platform/dri/hardware_display_plane.h (right):

https://codereview.chromium.org/383193002/diff/20001/ui/ozone/platform/dri/ha...
ui/ozone/platform/dri/hardware_display_plane.h:53: drmModePlanePtr plane_;
Please create a wrapper in scoped_drm_types.h and use that.

[alexst (slow to review), 2014-07-11 20:19:44]

PTAL

https://codereview.chromium.org/383193002/diff/20001/ui/ozone/platform/dri/dr...
File ui/ozone/platform/dri/dri.gypi (right):

https://codereview.chromium.org/383193002/diff/20001/ui/ozone/platform/dri/dr...
ui/ozone/platform/dri/dri.gypi:16: 'use_drm_atomic_flip%': 0,
On 2014/07/11 15:24:04, dnicoara wrote:
> One thing that I forgot to mention yesterday was testing without having this
> present in your GYP_DEFINES.

I did it today, it works as expected by flipping this flag.

https://codereview.chromium.org/383193002/diff/20001/ui/ozone/platform/dri/ha...
File ui/ozone/platform/dri/hardware_display_plane.cc (right):

https://codereview.chromium.org/383193002/diff/20001/ui/ozone/platform/dri/ha...
ui/ozone/platform/dri/hardware_display_plane.cc:98: drmModeObjectPropertiesPtr
plane_props = drmModeObjectGetProperties(
On 2014/07/11 15:24:04, dnicoara wrote:
> Could you please add the type to scoped_drm_types.h and use that instead. This
> is defined in the current API, so shouldn't require any fancy #ifdefs.

Good point, done.

https://codereview.chromium.org/383193002/diff/20001/ui/ozone/platform/dri/ha...
File ui/ozone/platform/dri/hardware_display_plane.h (right):

https://codereview.chromium.org/383193002/diff/20001/ui/ozone/platform/dri/ha...
ui/ozone/platform/dri/hardware_display_plane.h:53: drmModePlanePtr plane_;
On 2014/07/11 15:24:04, dnicoara wrote:
> Please create a wrapper in scoped_drm_types.h and use that.

Done.

[dnicoara, 2014-07-11 20:28:34]

lgtm

nit: "BUG=none" in CL description

https://codereview.chromium.org/383193002/diff/30001/ui/ozone/platform/dri/ha...
File ui/ozone/platform/dri/hardware_display_plane.h (right):

https://codereview.chromium.org/383193002/diff/30001/ui/ozone/platform/dri/ha...
ui/ozone/platform/dri/hardware_display_plane.h:27: drmModePlanePtr plane);
nit: have it take a ScopedDrmPlanePtr instead. That'll make ownership transfer
very clear.

[alexst (slow to review), 2014-07-11 21:55:48]

The CQ bit was checked by alexst@chromium.org

[commit-bot: I haz the power, 2014-07-11 21:58:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/alexst@chromium.org/383193002/50001

[commit-bot: I haz the power, 2014-07-12 01:32:24]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-07-12 04:58:36]

Change committed as 282803