Issue 383183002: Large timeouts between in-session portal detection attempts.

Issue 383183002: Large timeouts between in-session portal detection attempts. (Closed)

Created:
6 years, 5 months ago by ygorshenin1

Modified:
6 years, 5 months ago

Reviewers:
Nikita (slow), pneubeck (no reviews)

CC:
chromium-reviews, cbentzel+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Large timeouts between in-session portal detection attempts. https://codereview.chromium.org/385553002/ uses BackoffEntry, but it requires a lot of changes, so it probably won't be merged to M37. I suggest to merge this small fix. BUG=377725 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283536

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix. #

Patch Set 3 : Added OWNERS file for chromeos/network/portal_detector. #

Total comments: 2

Patch Set 4 : Fix, rebase. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -4 lines)			Patch
	A	chromeos/network/portal_detector/OWNERS	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
	M	chromeos/network/portal_detector/network_portal_detector_strategy.cc	View		2 chunks	+20 lines, -4 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

lgtm https://codereview.chromium.org/383183002/diff/1/chrome/browser/chromeos/net/network_portal_detector_impl.cc File chrome/browser/chromeos/net/network_portal_detector_impl.cc (right): https://codereview.chromium.org/383183002/diff/1/chrome/browser/chromeos/net/network_portal_detector_impl.cc#newcode399 chrome/browser/chromeos/net/network_portal_detector_impl.cc:399: LOG(ERROR) << "Scheduling attempt after: " << next_attempt_delay_.InSeconds(); ...

6 years, 5 months ago (2014-07-14 09:16:49 UTC) #2

ygorshenin1

+ Philipp for chromeos/network/portal_detector/* PTAL https://codereview.chromium.org/383183002/diff/1/chromeos/network/portal_detector/network_portal_detector_strategy.cc File chromeos/network/portal_detector/network_portal_detector_strategy.cc (right): https://codereview.chromium.org/383183002/diff/1/chromeos/network/portal_detector/network_portal_detector_strategy.cc#newcode105 chromeos/network/portal_detector/network_portal_detector_strategy.cc:105: virtual base::TimeDelta GetNextAttemptTimeoutImpl() OVERRIDE ...

6 years, 5 months ago (2014-07-14 09:29:44 UTC) #3

pneubeck (no reviews)

lgtm https://codereview.chromium.org/383183002/diff/10003/chromeos/network/portal_detector/OWNERS File chromeos/network/portal_detector/OWNERS (right): https://codereview.chromium.org/383183002/diff/10003/chromeos/network/portal_detector/OWNERS#newcode1 chromeos/network/portal_detector/OWNERS:1: per-file network_portal*=ygorshenin@chromium.org per-file not required

6 years, 5 months ago (2014-07-16 07:31:40 UTC) #4

ygorshenin1

Many thanks! https://codereview.chromium.org/383183002/diff/10003/chromeos/network/portal_detector/OWNERS File chromeos/network/portal_detector/OWNERS (right): https://codereview.chromium.org/383183002/diff/10003/chromeos/network/portal_detector/OWNERS#newcode1 chromeos/network/portal_detector/OWNERS:1: per-file network_portal*=ygorshenin@chromium.org On 2014/07/16 07:31:39, pneubeck wrote: ...

6 years, 5 months ago (2014-07-16 09:20:48 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/383183002/50001

6 years, 5 months ago (2014-07-16 09:22:29 UTC) #7

Message was sent while issue was closed.

Change committed as 283536

Expand Messages | Collapse Messages