Source/core/page/FrameTree.cpp - Issue 383153007: Fixes for re-enabling more MSVC level 4 warnings: Source/core/ edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/FrameTree.cpp

Issue 383153007: Fixes for re-enabling more MSVC level 4 warnings: Source/core/ edition (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Delete temp file Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/FrameTree.cpp

diff --git a/Source/core/page/FrameTree.cpp b/Source/core/page/FrameTree.cpp

index 657e2bf349dd8c747bc7c71014f7515d8cd0b213..fb894179bfdf928b6f362b44704194264903be6a 100644

--- a/Source/core/page/FrameTree.cpp

+++ b/Source/core/page/FrameTree.cpp

@@ -38,7 +38,7 @@ namespace WebCore {

namespace {

-const unsigned invalidChildCount = ~0;

+const unsigned invalidChildCount = ~static_cast<unsigned>(0);

dmazzoni 2014/07/16 21:21:16 No strong preference, but I wonder if UINT_MAX or

Peter Kasting 2014/07/16 23:06:58 0xffffffff wouldn't be good in case int isn't 32 b

} // namespace