Fixes for re-enabling more MSVC level 4 warnings: Source/core/ edition

Source/core/editing/TextIterator.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2005 Alexey Proskuryakov.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 911 matching lines @@
         && !r->isFloatingOrOutOfFlowPositioned() && !r->isBody() && !r->isRubyText();
 }
 
 static bool shouldEmitNewlineAfterNode(Node& node)
 {
     // FIXME: It should be better but slower to create a VisiblePosition here.
     if (!shouldEmitNewlinesBeforeAndAfterNode(node))
         return false;
     // Check if this is the very last renderer in the document.
     // If so, then we should not emit a newline.
-    Node* next = &node;
-    while ((next = NodeTraversal::nextSkippingChildren(*next))) {
+    for (Node* next = NodeTraversal::nextSkippingChildren(node); next; next = NodeTraversal::nextSkippingChildren(*next)) {

[dmazzoni, 2014/07/16 21:21:16]

To me, duplicating NodeTraversal::nextSkippingChildren(node) in order to avoid
the compiler warning hurts readability. How about:

Node* next = &node;
do {
  next = NodeTraversal::nextSkippingChildren(*next);
  if (next && next->renderer())
      return true;
} while (next);

[Peter Kasting, 2014/07/16 23:06:58]

I really find this significantly less readable than the form I had (while loops
in general and duplicated conditions between the middle and the end of the loop
fry my brain), but I'd prefer not to spend time arguing about it.  Done.

         if (next->renderer())
             return true;
     }
     return false;
 }
 
 static bool shouldEmitNewlineBeforeNode(Node& node)
 {
     return shouldEmitNewlinesBeforeAndAfterNode(node);
 }
@@ skipping 1270 matching lines @@
             resultEnd = collapseTo;
             return;
         }
     }
 
     CharacterIterator computeRangeIterator(inputStart, inputEnd, iteratorFlagsForFindPlainText);
     calculateCharacterSubrange(computeRangeIterator, matchStart, matchLength, resultStart, resultEnd);
 }
 
 }