Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: ppapi/proxy/ppb_image_data_proxy.cc

Issue 383143003: Pepper: Make sure 'out' params are initialized for all code paths. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Don't "fix" URLUtil. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/ppb_image_data_proxy.cc
diff --git a/ppapi/proxy/ppb_image_data_proxy.cc b/ppapi/proxy/ppb_image_data_proxy.cc
index 51751668f228dd9fef77218feabfcf55010eef47..4ed4442ceb4c4a8512f6cd6032c54190153df73f 100644
--- a/ppapi/proxy/ppb_image_data_proxy.cc
+++ b/ppapi/proxy/ppb_image_data_proxy.cc
@@ -494,9 +494,7 @@ PP_Resource PPB_ImageData_Proxy::CreateProxyResource(
}
HostResource result;
- // Initialize desc so we don't send unitialized memory over IPC.
- // https://crbug.com/391023.
- PP_ImageDataDesc desc = {};
+ PP_ImageDataDesc desc;
switch (type) {
case PPB_ImageData_Shared::SIMPLE: {
ppapi::proxy::SerializedHandle image_handle_wrapper;
@@ -622,6 +620,9 @@ void PPB_ImageData_Proxy::OnHostMsgCreatePlatform(
HostResource* result,
PP_ImageDataDesc* desc,
ImageHandle* result_image_handle) {
+ // Clear |desc| so we don't send unitialized memory to the plugin.
+ // https://crbug.com/391023.
+ *desc = PP_ImageDataDesc();
IPC::PlatformFileForTransit image_handle;
uint32_t byte_count;
PP_Resource resource =
@@ -647,6 +648,9 @@ void PPB_ImageData_Proxy::OnHostMsgCreateSimple(
HostResource* result,
PP_ImageDataDesc* desc,
ppapi::proxy::SerializedHandle* result_image_handle) {
+ // Clear |desc| so we don't send unitialized memory to the plugin.
+ // https://crbug.com/391023.
+ *desc = PP_ImageDataDesc();
IPC::PlatformFileForTransit image_handle;
uint32_t byte_count;
PP_Resource resource =
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698